Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2163133004: Move xfa_document to cxfa_document (Closed)

Created:
4 years, 5 months ago by dsinclair
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com, npm_g
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa_parser_II
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move xfa_document to cxfa_document This moves the code to match the actual class name. Committed: https://pdfium.googlesource.com/pdfium/+/16280245cab39fe646a97030940771bc105a1115

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -677 lines) Patch
M BUILD.gn View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M xfa.gyp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdoc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffnotify.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/include/xfa_ffdoc.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/include/xfa_ffwidgethandler.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cscript_datawindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cscript_eventpseudomodel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cscript_hostpseudomodel.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cscript_hostpseudomodel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cscript_layoutpseudomodel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cscript_logpseudomodel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cscript_signaturepseudomodel.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + xfa/fxfa/parser/cxfa_document.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + xfa/fxfa/parser/cxfa_document.cpp View 12 chunks +110 lines, -97 lines 0 comments Download
M xfa/fxfa/parser/cxfa_document_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_layoutitem.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_layoutprocessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_node.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_nodehelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_nodelist.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_object.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_resolveprocessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_scriptcontext.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_scriptcontext.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_simple_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_widgetdata.cpp View 1 chunk +1 line, -1 line 0 comments Download
D xfa/fxfa/parser/xfa_document.h View 1 chunk +0 lines, -126 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_datamerger_imp.cpp View 1 chunk +1 line, -1 line 0 comments Download
D xfa/fxfa/parser/xfa_document_imp.cpp View 1 chunk +0 lines, -414 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_serialize.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_appadapter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_itemlayout.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_pagemgr_new.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_locale.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_localemgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_localevalue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_utils_imp.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2170473002 Patch 100001

Dependent Patchsets:

Issue 2164663004 Patch 20001
Issue 2164663004 Patch 40001

Messages

Total messages: 8 (4 generated)
dsinclair
PTAL.
4 years, 5 months ago (2016-07-20 15:48:23 UTC) #2
Lei Zhang
lgtm
4 years, 5 months ago (2016-07-20 22:52:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163133004/80001
4 years, 5 months ago (2016-07-21 19:03:28 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 19:03:52 UTC) #8
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/16280245cab39fe646a97030940771bc105a...

Powered by Google App Engine
This is Rietveld 408576698