Add logic to convert from RenderPassDrawQuads to CALayerOverlays.

Add logic to convert from RenderPassDrawQuads to CALayerOverlays.

The logic isn't turned on because the GPU process doesn't support filter
effects yet.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/8cb37e8ac9633af50e928198d4792557252fdae4
Cr-Commit-Position: refs/heads/master@{#406981}

[erikchen, 2016-07-20 01:20:04]

Description was changed from

==========
Add logic to convert from RenderPassDrawQuads to CALayerOverlays.

The logic isn't turned on because the GPU process doesn't support filter
effects yet.

BUG=581526
==========

to

==========
Add logic to convert from RenderPassDrawQuads to CALayerOverlays.

The logic isn't turned on because the GPU process doesn't support filter
effects yet.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[erikchen, 2016-07-20 01:51:34]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2016-07-20 01:51:45]

erikchen@chromium.org changed reviewers:
+ ccameron@chromium.org

[erikchen, 2016-07-20 01:51:46]

ccameron: Please review.

[commit-bot: I haz the power, 2016-07-20 01:52:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 02:15:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 02:15:15]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[erikchen, 2016-07-21 01:44:44]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2016-07-21 01:44:58]

ccameron: PTAL

[commit-bot: I haz the power, 2016-07-21 01:44:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 02:05:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 02:05:27]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ccameron, 2016-07-21 05:44:56]

lg mod the encoding bit

https://codereview.chromium.org/2164613003/diff/80001/ui/gl/ca_renderer_layer...
File ui/gl/ca_renderer_layer_params.h (right):

https://codereview.chromium.org/2164613003/diff/80001/ui/gl/ca_renderer_layer...
ui/gl/ca_renderer_layer_params.h:71: int32_t data[4] = {0};
I'd think it better to do:
  float amount = 0;
  gfx::PointF drop_shadow_offset;
  unsigned drop_shadow_color = 0;

If we need to do any sort of encoding to get this through the command buffer, we
should do that at the call site (I assume that's the motivation for the packing
here?).

[erikchen, 2016-07-21 16:28:04]

ccameron: PTAL

https://codereview.chromium.org/2164613003/diff/80001/ui/gl/ca_renderer_layer...
File ui/gl/ca_renderer_layer_params.h (right):

https://codereview.chromium.org/2164613003/diff/80001/ui/gl/ca_renderer_layer...
ui/gl/ca_renderer_layer_params.h:71: int32_t data[4] = {0};
On 2016/07/21 05:44:56, ccameron wrote:
> I'd think it better to do:
>   float amount = 0;
>   gfx::PointF drop_shadow_offset;
>   unsigned drop_shadow_color = 0;
> 
> If we need to do any sort of encoding to get this through the command buffer,
we
> should do that at the call site (I assume that's the motivation for the
packing
> here?).

duh, good point. Done.

[ccameron, 2016-07-21 18:11:39]

lgtm

https://codereview.chromium.org/2164613003/diff/120001/cc/output/ca_layer_ove...
File cc/output/ca_layer_overlay.cc (right):

https://codereview.chromium.org/2164613003/diff/120001/cc/output/ca_layer_ove...
cc/output/ca_layer_overlay.cc:128: return CA_LAYER_SUCCESS;
This probably breaks the unittests added, maybe make it a global somewhere and
set it in the tests (or whatever).

[erikchen, 2016-07-21 18:18:26]

https://codereview.chromium.org/2164613003/diff/120001/cc/output/ca_layer_ove...
File cc/output/ca_layer_overlay.cc (right):

https://codereview.chromium.org/2164613003/diff/120001/cc/output/ca_layer_ove...
cc/output/ca_layer_overlay.cc:128: return CA_LAYER_SUCCESS;
On 2016/07/21 18:11:39, ccameron wrote:
> This probably breaks the unittests added, maybe make it a global somewhere and
> set it in the tests (or whatever).

g_allow_rpdq_quad_conversion is a global set by tests.

[erikchen, 2016-07-21 18:18:30]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-07-21 18:19:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-07-21 18:21:47]

On 2016/07/21 18:18:26, erikchen wrote:
>
https://codereview.chromium.org/2164613003/diff/120001/cc/output/ca_layer_ove...
> File cc/output/ca_layer_overlay.cc (right):
> 
>
https://codereview.chromium.org/2164613003/diff/120001/cc/output/ca_layer_ove...
> cc/output/ca_layer_overlay.cc:128: return CA_LAYER_SUCCESS;
> On 2016/07/21 18:11:39, ccameron wrote:
> > This probably breaks the unittests added, maybe make it a global somewhere
and
> > set it in the tests (or whatever).
> 
> g_allow_rpdq_quad_conversion is a global set by tests.

D'oh, missed that function

[commit-bot: I haz the power, 2016-07-21 18:28:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 18:28:50]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[erikchen, 2016-07-21 19:48:58]

erikchen@chromium.org changed reviewers:
+ isherman@chromium.org

[erikchen, 2016-07-21 19:48:59]

isherman: Please review tools/metrics/histograms

[erikchen, 2016-07-21 19:49:23]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 19:49:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 19:59:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 19:59:56]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[erikchen, 2016-07-21 20:12:17]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 20:12:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 20:25:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 20:25:34]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ilya Sherman, 2016-07-21 20:40:05]

histograms.xml lgtm

[erikchen, 2016-07-21 20:41:22]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-07-21 20:41:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
ccameron@chromium.org
Link to the patchset: https://codereview.chromium.org/2164613003/#ps160001
(title: "Compile error.")

[commit-bot: I haz the power, 2016-07-21 20:41:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 20:50:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 20:51:00]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[erikchen, 2016-07-21 20:58:51]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-07-21 20:58:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, ccameron@chromium.org
Link to the patchset: https://codereview.chromium.org/2164613003/#ps180001
(title: "Compile errors.")

[commit-bot: I haz the power, 2016-07-21 20:59:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 22:52:26]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-07-21 22:55:11]

Description was changed from

==========
Add logic to convert from RenderPassDrawQuads to CALayerOverlays.

The logic isn't turned on because the GPU process doesn't support filter
effects yet.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
Add logic to convert from RenderPassDrawQuads to CALayerOverlays.

The logic isn't turned on because the GPU process doesn't support filter
effects yet.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/8cb37e8ac9633af50e928198d4792557252fdae4
Cr-Commit-Position: refs/heads/master@{#406981}
==========

[commit-bot: I haz the power, 2016-07-21 22:55:12]

Patchset 10 (id:??) landed as
https://crrev.com/8cb37e8ac9633af50e928198d4792557252fdae4
Cr-Commit-Position: refs/heads/master@{#406981}