Add browsertest for permission action reporting

Add browsertest for permission action reporting

MockReportSender class is refactored from chrome/browser/safe_browsing/permission_reporter_unittest.cc
into chrome/browser/safe_browsing/mock_permission_report_sender.cc and renamed to MockPermissionReportSender so that it can be used in chrome/browser/safe_browsing/permission_reporter_browsertest.cc

BUG=613883
Committed: https://crrev.com/d95c8fb090d3c2c2e13649740d567c260109cba8
Cr-Commit-Position: refs/heads/master@{#408346}

[stefanocs, 2016-07-19 07:10:01]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 07:10:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stefanocs, 2016-07-19 08:01:29]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 08:01:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stefanocs, 2016-07-19 08:05:55]

stefanocs@google.com changed reviewers:
+ kcarattini@chromium.org, nparker@chromium.org, raymes@chromium.org

[stefanocs, 2016-07-19 11:01:30]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 11:01:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 11:13:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 11:13:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stefanocs, 2016-07-19 11:18:25]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 11:18:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 11:35:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 11:35:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stefanocs, 2016-07-19 11:39:53]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 11:40:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 11:54:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 11:54:08]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[stefanocs, 2016-07-19 12:04:10]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 12:04:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 13:02:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 13:02:32]

Dry run: This issue passed the CQ dry run.

[kcarattini, 2016-07-20 03:59:22]

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
File chrome/browser/safe_browsing/permission_reporter_browsertest.cc (right):

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:22: #if
!defined(OS_ANDROID)
With all these directives it might make sense to have separate tests entirely
for Android and ChromeOS. What do you think?

[stefanocs, 2016-07-20 04:47:26]

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
File chrome/browser/safe_browsing/permission_reporter_browsertest.cc (right):

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:22: #if
!defined(OS_ANDROID)
On 2016/07/20 03:59:22, kcarattini wrote:
> With all these directives it might make sense to have separate tests entirely
> for Android and ChromeOS. What do you think?

I think there would be too much intersecting code if we separate the tests.
Looking at the other browsertests, I think using directives is a common
approach.

[stefanocs, 2016-07-25 03:45:45]

stefanocs@google.com changed reviewers:
+ jialiul@chromium.org, vakh@chromium.org
- nparker@chromium.org

[stefanocs, 2016-07-25 03:45:46]

Hi,

Please help me review this permission reporting cl.

Thanks.

[raymes, 2016-07-25 04:31:40]

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
File chrome/browser/safe_browsing/permission_reporter_browsertest.cc (right):

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:38: constexpr
char kTestingUsername[] = "fake_username";
nit: just move these down to the place where they are used

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:42: class
MockReportSender : public net::ReportSender {
Can we factor this out into a separate file? It looks like a duplicate of what's
in chrome/browser/safe_browsing/permission_reporter_unittest.cc

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:72: class
PermissionReporterBrowserTest : public InProcessBrowserTest {
Can we have a base class PermissionReporterBrowserTest and then two separate
subclasses for android and desktop?

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:75:
~PermissionReporterBrowserTest() override = default;
nit: are these actually needed?

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:80:
mock_report_sender_ = new MockReportSender;
nit: perhaps create this in AttachMockReportSenderOnIOThread so the lifetime is
more clear?

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:99:
browser()->tab_strip_model()->GetActiveWebContents());
Is this actually needed? I see it only in unittests.

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:126: void
SetUpCommandLine(base::CommandLine* command_line) override {
nit: move this up closer to TearDown

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:171:
PermissionActionReporting) {
We can have separate tests for android/desktop. A bit of duplicate code in test
bodies is quite common. If you need to you could extract it into helper
functions to check results/etc.

[stefanocs, 2016-07-25 11:40:01]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 11:40:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stefanocs, 2016-07-25 12:06:43]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 12:06:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stefanocs, 2016-07-25 12:44:05]

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
File chrome/browser/safe_browsing/permission_reporter_browsertest.cc (right):

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:38: constexpr
char kTestingUsername[] = "fake_username";
On 2016/07/25 04:31:40, raymes wrote:
> nit: just move these down to the place where they are used

Done.

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:42: class
MockReportSender : public net::ReportSender {
On 2016/07/25 04:31:40, raymes wrote:
> Can we factor this out into a separate file? It looks like a duplicate of
what's
> in chrome/browser/safe_browsing/permission_reporter_unittest.cc

Where would be an appropriate place for this?
net/url_request/mock_report_sender.h?

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:72: class
PermissionReporterBrowserTest : public InProcessBrowserTest {
On 2016/07/25 04:31:40, raymes wrote:
> Can we have a base class PermissionReporterBrowserTest and then two separate
> subclasses for android and desktop?

Done.

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:75:
~PermissionReporterBrowserTest() override = default;
On 2016/07/25 04:31:40, raymes wrote:
> nit: are these actually needed?

Done.

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:80:
mock_report_sender_ = new MockReportSender;
On 2016/07/25 04:31:40, raymes wrote:
> nit: perhaps create this in AttachMockReportSenderOnIOThread so the lifetime
is
> more clear?

Done.

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:99:
browser()->tab_strip_model()->GetActiveWebContents());
On 2016/07/25 04:31:40, raymes wrote:
> Is this actually needed? I see it only in unittests.

I'm not sure. Actually I haven't tested this on Android since I have no way of
running it. Where should this file be added to so that it would run in Android
browsertest?

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:126: void
SetUpCommandLine(base::CommandLine* command_line) override {
On 2016/07/25 04:31:40, raymes wrote:
> nit: move this up closer to TearDown

Done.

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:171:
PermissionActionReporting) {
On 2016/07/25 04:31:40, raymes wrote:
> We can have separate tests for android/desktop. A bit of duplicate code in
test
> bodies is quite common. If you need to you could extract it into helper
> functions to check results/etc.

Done.

[commit-bot: I haz the power, 2016-07-25 12:54:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 12:54:23]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[raymes, 2016-07-26 00:45:02]

Let's get rid of the android test (since it won't be run) and file a bug.

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
File chrome/browser/safe_browsing/permission_reporter_browsertest.cc (right):

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:42: class
MockReportSender : public net::ReportSender {
On 2016/07/25 12:44:05, stefanocs wrote:
> On 2016/07/25 04:31:40, raymes wrote:
> > Can we factor this out into a separate file? It looks like a duplicate of
> what's
> > in chrome/browser/safe_browsing/permission_reporter_unittest.cc
> 
> Where would be an appropriate place for this?
> net/url_request/mock_report_sender.h?

chrome/browser/safe_browsing/ should be fine

[stefanocs, 2016-07-26 01:48:49]

Description was changed from

==========
Add browsertest for permission action reporting

BUG=613883
==========

to

==========
Add browsertest for permission action reporting

MockReportSender class is refactored from
chrome/browser/safe_browsing/permission_reporter_unittest.cc
into chrome/browser/safe_browsing/mock_report_sender.cc so that it can be used
in chrome/browser/safe_browsing/permission_reporter_browsertest.cc

BUG=613883
==========

[stefanocs, 2016-07-26 01:48:58]

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
File chrome/browser/safe_browsing/permission_reporter_browsertest.cc (right):

https://codereview.chromium.org/2164513002/diff/120001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:42: class
MockReportSender : public net::ReportSender {
On 2016/07/26 00:45:02, raymes wrote:
> On 2016/07/25 12:44:05, stefanocs wrote:
> > On 2016/07/25 04:31:40, raymes wrote:
> > > Can we factor this out into a separate file? It looks like a duplicate of
> > what's
> > > in chrome/browser/safe_browsing/permission_reporter_unittest.cc
> > 
> > Where would be an appropriate place for this?
> > net/url_request/mock_report_sender.h?
> 
> chrome/browser/safe_browsing/ should be fine

Done.

[kcarattini, 2016-07-26 03:22:14]

lgtm

[raymes, 2016-07-26 07:42:06]

lgtm

https://codereview.chromium.org/2164513002/diff/180001/chrome/browser/safe_br...
File chrome/browser/safe_browsing/mock_report_sender.h (right):

https://codereview.chromium.org/2164513002/diff/180001/chrome/browser/safe_br...
chrome/browser/safe_browsing/mock_report_sender.h:5: #include
"net/url_request/report_sender.h"
nit: nothing should be above the guards

https://codereview.chromium.org/2164513002/diff/180001/chrome/browser/safe_br...
File chrome/browser/safe_browsing/permission_reporter_browsertest.cc (right):

https://codereview.chromium.org/2164513002/diff/180001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:84: void
AcceptBubble() { GetPermissionRequestManager()->Accept(); }
nit: probably just inline this

[stefanocs, 2016-07-26 11:17:37]

Thanks!

https://codereview.chromium.org/2164513002/diff/180001/chrome/browser/safe_br...
File chrome/browser/safe_browsing/mock_report_sender.h (right):

https://codereview.chromium.org/2164513002/diff/180001/chrome/browser/safe_br...
chrome/browser/safe_browsing/mock_report_sender.h:5: #include
"net/url_request/report_sender.h"
On 2016/07/26 07:42:06, raymes wrote:
> nit: nothing should be above the guards

Done.

https://codereview.chromium.org/2164513002/diff/180001/chrome/browser/safe_br...
File chrome/browser/safe_browsing/permission_reporter_browsertest.cc (right):

https://codereview.chromium.org/2164513002/diff/180001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:84: void
AcceptBubble() { GetPermissionRequestManager()->Accept(); }
On 2016/07/26 07:42:06, raymes wrote:
> nit: probably just inline this

Done.

[Jialiu Lin, 2016-07-26 16:28:02]

lgtm with nit

https://codereview.chromium.org/2164513002/diff/200001/chrome/browser/safe_br...
File chrome/browser/safe_browsing/mock_report_sender.h (right):

https://codereview.chromium.org/2164513002/diff/200001/chrome/browser/safe_br...
chrome/browser/safe_browsing/mock_report_sender.h:12: // A mock ReportSender
that keeps track of the last report sent.
could you change the class name/file name/comment to indicate this is for
permission report?  Since we have other kind of report (e.g. safe browsing hit
report, SB extended report etc) in the same directory.  Could be a little bit
confusing.

[stefanocs, 2016-07-27 04:10:39]

Description was changed from

==========
Add browsertest for permission action reporting

MockReportSender class is refactored from
chrome/browser/safe_browsing/permission_reporter_unittest.cc
into chrome/browser/safe_browsing/mock_report_sender.cc so that it can be used
in chrome/browser/safe_browsing/permission_reporter_browsertest.cc

BUG=613883
==========

to

==========
Add browsertest for permission action reporting

MockReportSender class is refactored from
chrome/browser/safe_browsing/permission_reporter_unittest.cc
into chrome/browser/safe_browsing/mock_permission_report_sender.cc and renamed
to MockPermissionReportSender so that it can be used in
chrome/browser/safe_browsing/permission_reporter_browsertest.cc

BUG=613883
==========

[stefanocs, 2016-07-27 04:11:19]

https://codereview.chromium.org/2164513002/diff/180001/chrome/browser/safe_br...
File chrome/browser/safe_browsing/permission_reporter_browsertest.cc (right):

https://codereview.chromium.org/2164513002/diff/180001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:84: void
AcceptBubble() { GetPermissionRequestManager()->Accept(); }
On 2016/07/26 07:42:06, raymes wrote:
> nit: probably just inline this

I changed this back. This cannot be inlined because Accept() can only be called
in a friend class.

https://codereview.chromium.org/2164513002/diff/200001/chrome/browser/safe_br...
File chrome/browser/safe_browsing/mock_report_sender.h (right):

https://codereview.chromium.org/2164513002/diff/200001/chrome/browser/safe_br...
chrome/browser/safe_browsing/mock_report_sender.h:12: // A mock ReportSender
that keeps track of the last report sent.
On 2016/07/26 16:28:02, Jialiu Lin wrote:
> could you change the class name/file name/comment to indicate this is for
> permission report?  Since we have other kind of report (e.g. safe browsing hit
> report, SB extended report etc) in the same directory.  Could be a little bit
> confusing. 

Done. Renamed the class to MockPermissionReportSender.

[stefanocs, 2016-07-27 06:12:21]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 06:12:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 06:14:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 06:14:18]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[stefanocs, 2016-07-27 06:46:23]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 06:46:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 06:48:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 06:48:40]

Dry run: Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[stefanocs, 2016-07-27 07:06:05]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 07:06:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 08:08:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 08:08:29]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[stefanocs, 2016-07-27 10:14:39]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 10:15:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 10:44:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 10:44:56]

Dry run: This issue passed the CQ dry run.

[stefanocs, 2016-07-28 05:11:40]

The CQ bit was checked by stefanocs@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 05:11:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 05:21:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 05:21:15]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[stefanocs, 2016-07-28 06:07:09]

The CQ bit was checked by stefanocs@google.com

[stefanocs, 2016-07-28 06:07:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
kcarattini@chromium.org, raymes@chromium.org, jialiul@chromium.org
Link to the patchset: https://codereview.chromium.org/2164513002/#ps300001
(title: "Add gesture test")

[commit-bot: I haz the power, 2016-07-28 06:07:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 06:21:50]

Description was changed from

==========
Add browsertest for permission action reporting

MockReportSender class is refactored from
chrome/browser/safe_browsing/permission_reporter_unittest.cc
into chrome/browser/safe_browsing/mock_permission_report_sender.cc and renamed
to MockPermissionReportSender so that it can be used in
chrome/browser/safe_browsing/permission_reporter_browsertest.cc

BUG=613883
==========

to

==========
Add browsertest for permission action reporting

MockReportSender class is refactored from
chrome/browser/safe_browsing/permission_reporter_unittest.cc
into chrome/browser/safe_browsing/mock_permission_report_sender.cc and renamed
to MockPermissionReportSender so that it can be used in
chrome/browser/safe_browsing/permission_reporter_browsertest.cc

BUG=613883
==========

[commit-bot: I haz the power, 2016-07-28 06:21:51]

Committed patchset #16 (id:300001)

[commit-bot: I haz the power, 2016-07-28 06:23:13]

Description was changed from

==========
Add browsertest for permission action reporting

MockReportSender class is refactored from
chrome/browser/safe_browsing/permission_reporter_unittest.cc
into chrome/browser/safe_browsing/mock_permission_report_sender.cc and renamed
to MockPermissionReportSender so that it can be used in
chrome/browser/safe_browsing/permission_reporter_browsertest.cc

BUG=613883
==========

to

==========
Add browsertest for permission action reporting

MockReportSender class is refactored from
chrome/browser/safe_browsing/permission_reporter_unittest.cc
into chrome/browser/safe_browsing/mock_permission_report_sender.cc and renamed
to MockPermissionReportSender so that it can be used in
chrome/browser/safe_browsing/permission_reporter_browsertest.cc

BUG=613883

Committed: https://crrev.com/d95c8fb090d3c2c2e13649740d567c260109cba8
Cr-Commit-Position: refs/heads/master@{#408346}
==========

[commit-bot: I haz the power, 2016-07-28 06:23:14]

Patchset 16 (id:??) landed as
https://crrev.com/d95c8fb090d3c2c2e13649740d567c260109cba8
Cr-Commit-Position: refs/heads/master@{#408346}