chrome/browser/permissions/permission_uma_util.cc - Issue 2164513002: Add browsertest for permission action reporting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2164513002: Add browsertest for permission action reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-hooks-to-permission-layer2

Patch Set: Add gesture test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/permissions/permission_request_manager.h ('k') | chrome/browser/safe_browsing/mock_permission_report_sender.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_uma_util.cc

diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc

index 31481f035059ed6b0a92a1e3f55f91611ccf634b..ee69985714e9488e9ed9e9af6eb372a8e6dec8ae 100644

--- a/chrome/browser/permissions/permission_uma_util.cc

+++ b/chrome/browser/permissions/permission_uma_util.cc

@@ -396,8 +396,6 @@ void PermissionUmaUtil::RecordPermissionAction(

const GURL& requesting_origin,

Profile* profile) {

if (IsOptedIntoPermissionActionReporting(profile)) {

- // TODO(stefanocs): Add browsertests to make sure the reports are being

- // sent.

g_browser_process->safe_browsing_service()

->ui_manager()

->ReportPermissionAction(requesting_origin, permission, action,