Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: chrome/browser/safe_browsing/permission_reporter_unittest.cc

Issue 2164513002: Add browsertest for permission action reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-hooks-to-permission-layer2
Patch Set: Add gesture test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/safe_browsing/permission_reporter.h" 5 #include "chrome/browser/safe_browsing/permission_reporter.h"
6 6
7 #include "base/feature_list.h" 7 #include "base/feature_list.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "base/metrics/field_trial.h" 9 #include "base/metrics/field_trial.h"
10 #include "base/test/simple_test_clock.h" 10 #include "base/test/simple_test_clock.h"
11 #include "base/time/time.h" 11 #include "base/time/time.h"
12 #include "chrome/browser/permissions/permission_request.h" 12 #include "chrome/browser/permissions/permission_request.h"
13 #include "chrome/browser/safe_browsing/mock_permission_report_sender.h"
13 #include "chrome/common/safe_browsing/permission_report.pb.h" 14 #include "chrome/common/safe_browsing/permission_report.pb.h"
14 #include "components/variations/active_field_trials.h" 15 #include "components/variations/active_field_trials.h"
15 #include "content/public/browser/permission_type.h" 16 #include "content/public/browser/permission_type.h"
16 #include "net/url_request/report_sender.h"
17 #include "testing/gtest/include/gtest/gtest.h" 17 #include "testing/gtest/include/gtest/gtest.h"
18 18
19 using content::PermissionType; 19 using content::PermissionType;
20 20
21 namespace safe_browsing { 21 namespace safe_browsing {
22 22
23 namespace { 23 namespace {
24 24
25 // URL to upload permission action reports. 25 // URL to upload permission action reports.
26 const char kPermissionActionReportingUploadUrl[] = 26 const char kPermissionActionReportingUploadUrl[] =
(...skipping 19 matching lines...) Expand all
46 const char kFeatureOnByDefaultName[] = "OnByDefault"; 46 const char kFeatureOnByDefaultName[] = "OnByDefault";
47 struct base::Feature kFeatureOnByDefault { 47 struct base::Feature kFeatureOnByDefault {
48 kFeatureOnByDefaultName, base::FEATURE_ENABLED_BY_DEFAULT 48 kFeatureOnByDefaultName, base::FEATURE_ENABLED_BY_DEFAULT
49 }; 49 };
50 50
51 const char kFeatureOffByDefaultName[] = "OffByDefault"; 51 const char kFeatureOffByDefaultName[] = "OffByDefault";
52 struct base::Feature kFeatureOffByDefault { 52 struct base::Feature kFeatureOffByDefault {
53 kFeatureOffByDefaultName, base::FEATURE_DISABLED_BY_DEFAULT 53 kFeatureOffByDefaultName, base::FEATURE_DISABLED_BY_DEFAULT
54 }; 54 };
55 55
56 // A mock ReportSender that keeps track of the last report sent.
57 class MockReportSender : public net::ReportSender {
58 public:
59 MockReportSender() : net::ReportSender(nullptr, DO_NOT_SEND_COOKIES) {
60 number_of_reports_ = 0;
61 }
62
63 ~MockReportSender() override {}
64
65 void Send(const GURL& report_uri, const std::string& report) override {
66 latest_report_uri_ = report_uri;
67 latest_report_ = report;
68 number_of_reports_++;
69 }
70
71 const GURL& latest_report_uri() { return latest_report_uri_; }
72
73 const std::string& latest_report() { return latest_report_; }
74
75 int GetAndResetNumberOfReportsSent() {
76 int new_reports = number_of_reports_;
77 number_of_reports_ = 0;
78 return new_reports;
79 }
80
81 private:
82 GURL latest_report_uri_;
83 std::string latest_report_;
84 int number_of_reports_;
85
86 DISALLOW_COPY_AND_ASSIGN(MockReportSender);
87 };
88
89 } // namespace 56 } // namespace
90 57
91 class PermissionReporterTest : public ::testing::Test { 58 class PermissionReporterTest : public ::testing::Test {
92 protected: 59 protected:
93 void SetUp() override { 60 void SetUp() override {
94 mock_report_sender_ = new MockReportSender; 61 mock_report_sender_ = new MockPermissionReportSender;
95 clock_ = new base::SimpleTestClock; 62 clock_ = new base::SimpleTestClock;
96 permission_reporter_.reset(new PermissionReporter( 63 permission_reporter_.reset(new PermissionReporter(
97 base::WrapUnique(mock_report_sender_), base::WrapUnique(clock_))); 64 base::WrapUnique(mock_report_sender_), base::WrapUnique(clock_)));
98 } 65 }
99 66
100 // Owned by |permission_reporter_|. 67 // Owned by |permission_reporter_|.
101 MockReportSender* mock_report_sender_; 68 MockPermissionReportSender* mock_report_sender_;
102 69
103 // Owned by |permission_reporter_|. 70 // Owned by |permission_reporter_|.
104 base::SimpleTestClock* clock_; 71 base::SimpleTestClock* clock_;
105 72
106 std::unique_ptr<PermissionReporter> permission_reporter_; 73 std::unique_ptr<PermissionReporter> permission_reporter_;
107 }; 74 };
108 75
109 // Test that PermissionReporter::SendReport sends a serialized report string to 76 // Test that PermissionReporter::SendReport sends a serialized report string to
110 // SafeBrowsing CSD servers. 77 // SafeBrowsing CSD servers.
111 TEST_F(PermissionReporterTest, SendReport) { 78 TEST_F(PermissionReporterTest, SendReport) {
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 clock_->Advance(base::TimeDelta::FromSeconds(5)); 201 clock_->Advance(base::TimeDelta::FromSeconds(5));
235 permission_reporter_->SendReport(GURL(kDummyOriginOne), kDummyPermissionOne, 202 permission_reporter_->SendReport(GURL(kDummyOriginOne), kDummyPermissionOne,
236 kDummyAction, kDummySourceUI, 203 kDummyAction, kDummySourceUI,
237 kDummyGestureType); 204 kDummyGestureType);
238 } 205 }
239 EXPECT_EQ(kMaximumReportsPerOriginPerPermissionPerMinute, 206 EXPECT_EQ(kMaximumReportsPerOriginPerPermissionPerMinute,
240 mock_report_sender_->GetAndResetNumberOfReportsSent()); 207 mock_report_sender_->GetAndResetNumberOfReportsSent());
241 } 208 }
242 209
243 } // namespace safe_browsing 210 } // namespace safe_browsing
OLDNEW
« no previous file with comments | « chrome/browser/safe_browsing/permission_reporter_browsertest.cc ('k') | chrome/browser/safe_browsing/ping_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698