Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2164353002: [DevTools] Unify toValue and FromValue into ValueConversions. (Closed)

Created:
4 years, 5 months ago by dgozman
Modified:
4 years, 5 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, aboxhall, pfeldman+blink_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, haraken, nektarios, je_julie, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, lushnikov+blink_chromium.org, dmazzoni, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Unify toValue and FromValue into ValueConversions. BUG=none TBR=pfeldman Committed: https://crrev.com/dc5d0632171363ab683aa84754db3b35d6ed39a8 Cr-Commit-Position: refs/heads/master@{#407027}

Patch Set 1 #

Messages

Total messages: 14 (7 generated)
dgozman
Take a look please!
4 years, 5 months ago (2016-07-21 17:46:47 UTC) #2
caseq
lgtm
4 years, 5 months ago (2016-07-21 21:31:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164353002/1
4 years, 5 months ago (2016-07-21 21:32:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/222734)
4 years, 5 months ago (2016-07-21 21:49:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2164353002/1
4 years, 5 months ago (2016-07-21 21:55:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 03:31:27 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 03:33:47 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc5d0632171363ab683aa84754db3b35d6ed39a8
Cr-Commit-Position: refs/heads/master@{#407027}

Powered by Google App Engine
This is Rietveld 408576698