Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp

Issue 2164353002: [DevTools] Unify toValue and FromValue into ValueConversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/blink_platform.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp b/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp
index fdaff041792dedfff5bdf742ddcc37b0af3e1a32..d1365a1b7b3cfff7720b6cc429bd045085ad8b01 100644
--- a/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp
@@ -69,22 +69,22 @@ std::unique_ptr<AXProperty> createProperty(IgnoredReason reason)
std::unique_ptr<AXValue> createValue(const String& value, const String& type)
{
- return AXValue::create().setType(type).setValue(protocol::toValue(value)).build();
+ return AXValue::create().setType(type).setValue(protocol::ValueConversions<String>::serialize(value)).build();
}
std::unique_ptr<AXValue> createValue(int value, const String& type)
{
- return AXValue::create().setType(type).setValue(protocol::toValue(value)).build();
+ return AXValue::create().setType(type).setValue(protocol::ValueConversions<int>::serialize(value)).build();
}
std::unique_ptr<AXValue> createValue(float value, const String& type)
{
- return AXValue::create().setType(type).setValue(protocol::toValue(value)).build();
+ return AXValue::create().setType(type).setValue(protocol::ValueConversions<double>::serialize(value)).build();
}
std::unique_ptr<AXValue> createBooleanValue(bool value, const String& type)
{
- return AXValue::create().setType(type).setValue(protocol::toValue(value)).build();
+ return AXValue::create().setType(type).setValue(protocol::ValueConversions<bool>::serialize(value)).build();
}
std::unique_ptr<AXRelatedNode> relatedNodeForAXObject(const AXObject* axObject, String* name = nullptr)
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/blink_platform.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698