RFC: Make BisonCSSParser purely stack allocated.

RFC: Make BisonCSSParser purely stack allocated.

I was looking at how to port the BisonCSSParser and CSSParserObserver to the oilpan (GC) heap and noticed that we had a pointer from the BisonCSSParser back to the stack allocated CSSParserObserver/StyleSheetHandler. While it worked correctly making the BisonCSSParser stack allocated will IMO simplify the lifetime reasoning and make it less likely that we introduce errors.
This comes at the "expense" of always allocating a comment parser in the StyleSheetHandler. It is only used in the Inspector code so I am hoping that is okay.

R=ager@chromium.org, erik.corry@gmail.com, eseidel@chromium.org, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170530

[haraken, 2014-03-28 11:50:53]

LGTM. I agree this CL is making the lifetime clearer.

https://codereview.chromium.org/216433003/diff/1/Source/core/css/parser/Bison...
File Source/core/css/parser/BisonCSSParser.h (right):

https://codereview.chromium.org/216433003/diff/1/Source/core/css/parser/Bison...
Source/core/css/parser/BisonCSSParser.h:84: BisonCSSParser(const
CSSParserContext&);

Add explicit.

https://codereview.chromium.org/216433003/diff/1/Source/core/css/parser/Bison...
Source/core/css/parser/BisonCSSParser.h:85: BisonCSSParser(Document*);

Add explicit.

[wibling-chromium, 2014-03-28 12:05:36]

Thanks for the review!

https://codereview.chromium.org/216433003/diff/1/Source/core/css/parser/Bison...
File Source/core/css/parser/BisonCSSParser.h (right):

https://codereview.chromium.org/216433003/diff/1/Source/core/css/parser/Bison...
Source/core/css/parser/BisonCSSParser.h:84: BisonCSSParser(const
CSSParserContext&);
On 2014/03/28 11:50:53, haraken wrote:
> 
> Add explicit.

Done.

https://codereview.chromium.org/216433003/diff/1/Source/core/css/parser/Bison...
Source/core/css/parser/BisonCSSParser.h:85: BisonCSSParser(Document*);
On 2014/03/28 11:50:53, haraken wrote:
> 
> Add explicit.

Done.

[lushnikov, 2014-03-28 21:28:30]

devtools lgtm

[eseidel, 2014-03-28 22:09:23]

https://codereview.chromium.org/216433003/diff/1/Source/core/css/parser/Bison...
File Source/core/css/parser/BisonCSSParser-in.cpp (right):

https://codereview.chromium.org/216433003/diff/1/Source/core/css/parser/Bison...
Source/core/css/parser/BisonCSSParser-in.cpp:115:
BisonCSSParser::BisonCSSParser(Document* document)
Why is this needed?  We could also add a parserContextForDocument(document)
function and keep a single constructor?

[wibling-chromium, 2014-03-31 08:06:35]

https://codereview.chromium.org/216433003/diff/1/Source/core/css/parser/Bison...
File Source/core/css/parser/BisonCSSParser-in.cpp (right):

https://codereview.chromium.org/216433003/diff/1/Source/core/css/parser/Bison...
Source/core/css/parser/BisonCSSParser-in.cpp:115:
BisonCSSParser::BisonCSSParser(Document* document)
On 2014/03/28 22:09:24, eseidel wrote:
> Why is this needed?  We could also add a parserContextForDocument(document)
> function and keep a single constructor?

Sure, I will do that instead of the constructor.

[wibling-chromium, 2014-03-31 10:58:48]

PTAL

[zerny-chromium, 2014-03-31 11:16:43]

lgtm

[haraken, 2014-03-31 11:26:19]

LGTM

[wibling-chromium, 2014-04-01 06:59:42]

The CQ bit was checked by wibling@chromium.org

[commit-bot: I haz the power, 2014-04-01 06:59:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wibling@chromium.org/216433003/20001

[eseidel, 2014-04-01 07:03:53]

lgtm

[commit-bot: I haz the power, 2014-04-01 07:10:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-01 07:10:43]

Try jobs failed on following builders:
  tryserver.blink on win_blink_compile_dbg

[wibling-chromium, 2014-04-01 07:25:12]

The CQ bit was checked by wibling@chromium.org

[commit-bot: I haz the power, 2014-04-01 07:25:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wibling@chromium.org/216433003/20001

[commit-bot: I haz the power, 2014-04-01 08:02:42]

Change committed as 170530