Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: Source/core/css/parser/BisonCSSParser.h

Issue 216433003: RFC: Make BisonCSSParser purely stack allocated. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Review feedback Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/css/parser/CSSParserObserver.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2008, 2009, 2010 Apple Inc. All rights reserv ed. 3 * Copyright (C) 2004, 2005, 2006, 2008, 2009, 2010 Apple Inc. All rights reserv ed.
4 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2009 - 2010 Torch Mobile (Beijing) Co. Ltd. All rights reserve d. 5 * Copyright (C) 2009 - 2010 Torch Mobile (Beijing) Co. Ltd. All rights reserve d.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 class UseCounter; 71 class UseCounter;
72 72
73 // FIXME: This class is shared with CSSTokenizer so should we rename it to CSSSo urceLocation? 73 // FIXME: This class is shared with CSSTokenizer so should we rename it to CSSSo urceLocation?
74 struct CSSParserLocation { 74 struct CSSParserLocation {
75 unsigned offset; 75 unsigned offset;
76 unsigned lineNumber; 76 unsigned lineNumber;
77 CSSParserString token; 77 CSSParserString token;
78 }; 78 };
79 79
80 class BisonCSSParser { 80 class BisonCSSParser {
81 STACK_ALLOCATED();
81 friend inline int cssyylex(void*, BisonCSSParser*); 82 friend inline int cssyylex(void*, BisonCSSParser*);
82
83 public: 83 public:
84 BisonCSSParser(const CSSParserContext&); 84 explicit BisonCSSParser(const CSSParserContext&);
85 ~BisonCSSParser(); 85 ~BisonCSSParser();
86 86
87 void rollbackLastProperties(int num); 87 void rollbackLastProperties(int num);
88 void setCurrentProperty(CSSPropertyID); 88 void setCurrentProperty(CSSPropertyID);
89 89
90 void parseSheet(StyleSheetContents*, const String&, const TextPosition& star tPosition = TextPosition::minimumPosition(), CSSParserObserver* = 0, bool = fals e); 90 void parseSheet(StyleSheetContents*, const String&, const TextPosition& star tPosition = TextPosition::minimumPosition(), CSSParserObserver* = 0, bool = fals e);
91 PassRefPtrWillBeRawPtr<StyleRuleBase> parseRule(StyleSheetContents*, const S tring&); 91 PassRefPtrWillBeRawPtr<StyleRuleBase> parseRule(StyleSheetContents*, const S tring&);
92 PassRefPtrWillBeRawPtr<StyleKeyframe> parseKeyframeRule(StyleSheetContents*, const String&); 92 PassRefPtrWillBeRawPtr<StyleKeyframe> parseKeyframeRule(StyleSheetContents*, const String&);
93 bool parseSupportsCondition(const String&); 93 bool parseSupportsCondition(const String&);
94 static bool parseValue(MutableStylePropertySet*, CSSPropertyID, const String &, bool important, CSSParserMode, StyleSheetContents*); 94 static bool parseValue(MutableStylePropertySet*, CSSPropertyID, const String &, bool important, CSSParserMode, StyleSheetContents*);
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 inline int cssyylex(void* yylval, BisonCSSParser* parser) 319 inline int cssyylex(void* yylval, BisonCSSParser* parser)
320 { 320 {
321 return parser->m_tokenizer.lex(yylval); 321 return parser->m_tokenizer.lex(yylval);
322 } 322 }
323 323
324 bool isValidNthToken(const CSSParserString&); 324 bool isValidNthToken(const CSSParserString&);
325 325
326 } // namespace WebCore 326 } // namespace WebCore
327 327
328 #endif // BisonCSSParser_h 328 #endif // BisonCSSParser_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/css/parser/CSSParserObserver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698