RFC: Make BisonCSSParser purely stack allocated.

Source/core/css/parser/BisonCSSParser-in.cpp

 /*
  * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
  * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
  * Copyright (C) 2012 Intel Corporation. All rights reserved.
  *
@@ skipping 89 matching lines @@
 
 using namespace std;
 using namespace WTF;
 
 namespace WebCore {
 
 static const unsigned INVALID_NUM_PARSED_PROPERTIES = UINT_MAX;
 
 BisonCSSParser::BisonCSSParser(const CSSParserContext& context)
     : m_context(context)
-    , m_important(false)
-    , m_id(CSSPropertyInvalid)
-    , m_styleSheet(0)
-    , m_supportsCondition(false)
-    , m_selectorListForParseSelector(0)
-    , m_numParsedPropertiesBeforeMarginBox(INVALID_NUM_PARSED_PROPERTIES)
-    , m_hasFontFaceOnlyValues(false)
-    , m_hadSyntacticallyValidCSSRule(false)
-    , m_logErrors(false)
-    , m_ignoreErrors(false)
-    , m_defaultNamespace(starAtom)
-    , m_observer(0)
-    , m_source(0)
-    , m_ruleHeaderType(CSSRuleSourceData::UNKNOWN_RULE)
-    , m_allowImportRules(true)
-    , m_allowNamespaceDeclarations(true)
-    , m_inViewport(false)
     , m_tokenizer(*this)
 {
+    init();
+}
+
+BisonCSSParser::BisonCSSParser(Document* document)

[eseidel, 2014/03/28 22:09:24]

Why is this needed?  We could also add a parserContextForDocument(document)
function and keep a single constructor?

[wibling-chromium, 2014/03/31 08:06:36]

Sure, I will do that instead of the constructor.

+    : m_context(document ? CSSParserContext(*document, 0) : strictCSSParserContext())
+    , m_tokenizer(*this)
+{
+    init();
+}
+
+void BisonCSSParser::init()
+{
+    m_important = false;
+    m_id = CSSPropertyInvalid;
+    m_styleSheet = 0;
+    m_supportsCondition = false;
+    m_selectorListForParseSelector = 0;
+    m_numParsedPropertiesBeforeMarginBox =INVALID_NUM_PARSED_PROPERTIES;
+    m_hasFontFaceOnlyValues = false;
+    m_hadSyntacticallyValidCSSRule = false;
+    m_logErrors = false;
+    m_ignoreErrors = false;
+    m_defaultNamespace = starAtom;
+    m_observer = 0;
+    m_source = 0;
+    m_ruleHeaderType = CSSRuleSourceData::UNKNOWN_RULE;
+    m_allowImportRules = true;
+    m_allowNamespaceDeclarations = true;
+    m_inViewport = false;
 #if YYDEBUG > 0
     cssyydebug = 1;
 #endif
     CSSPropertySourceData::init();
 }
 
 BisonCSSParser::~BisonCSSParser()
 {
     clearProperties();
 
@@ skipping 2029 matching lines @@
     rule->setProperties(createStylePropertySet());
     clearProperties();
 
     StyleRuleViewport* result = rule.get();
     m_parsedRules.append(rule.release());
 
     return result;
 }
 
 }