Simplify data channel creation logic in WebRTC-based protocol

Simplify data channel creation logic in WebRTC-based protocol

Previously WebrtcDataStreamAdapter was implementing MessageChannelFactory,
which means that it was always creating channels asynchronously and in OPEN
state. Refactored it to create channels in CONNECTING state. Significantly
simplifies channel setup code as it's always synchronous. It's also possible
to reject incoming channels before they are connected and handle channels
rejected by the peer before being fully connected.

Committed: https://crrev.com/cc40af91b15bd24efc02f82169ef1b76a5e35dbb
Cr-Commit-Position: refs/heads/master@{#407046}

[Sergey Ulanov, 2016-07-20 22:53:54]

sergeyu@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Jamie, 2016-07-22 01:10:16]

lgtm

https://codereview.chromium.org/2164163002/diff/1/remoting/protocol/webrtc_da...
File remoting/protocol/webrtc_data_stream_adapter.h (right):

https://codereview.chromium.org/2164163002/diff/1/remoting/protocol/webrtc_da...
remoting/protocol/webrtc_data_stream_adapter.h:25: // WebrtcDataStreamAdapter is
a MessageChannelFactory that creates channels that
Update the comment.

https://codereview.chromium.org/2164163002/diff/1/remoting/protocol/webrtc_da...
remoting/protocol/webrtc_data_stream_adapter.h:31: WebrtcDataStreamAdapter(
Why not explicit any more?

[Sergey Ulanov, 2016-07-22 01:20:37]

https://codereview.chromium.org/2164163002/diff/1/remoting/protocol/webrtc_da...
File remoting/protocol/webrtc_data_stream_adapter.h (right):

https://codereview.chromium.org/2164163002/diff/1/remoting/protocol/webrtc_da...
remoting/protocol/webrtc_data_stream_adapter.h:25: // WebrtcDataStreamAdapter is
a MessageChannelFactory that creates channels that
On 2016/07/22 01:10:16, Jamie wrote:
> Update the comment.

Done.

https://codereview.chromium.org/2164163002/diff/1/remoting/protocol/webrtc_da...
remoting/protocol/webrtc_data_stream_adapter.h:31: WebrtcDataStreamAdapter(
On 2016/07/22 01:10:16, Jamie wrote:
> Why not explicit any more?

Done.

[Sergey Ulanov, 2016-07-22 01:20:46]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-07-22 01:20:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/2164163002/#ps20001
(title: "nits")

[commit-bot: I haz the power, 2016-07-22 01:21:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 03:49:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-22 03:54:44]

Description was changed from

==========
Simplify data channel creation logic in WebRTC-based protocol

Previously WebrtcDataStreamAdapter was implementing MessageChannelFactory,
which means that it was always creating channels asynchronously and in OPEN
state. Refactored it to create channels in CONNECTING state. Significantly
simplifies channel setup code as it's always synchronous. It's also possible
to reject incoming channels before they are connected and handle channels
rejected by the peer before being fully connected.
==========

to

==========
Simplify data channel creation logic in WebRTC-based protocol

Previously WebrtcDataStreamAdapter was implementing MessageChannelFactory,
which means that it was always creating channels asynchronously and in OPEN
state. Refactored it to create channels in CONNECTING state. Significantly
simplifies channel setup code as it's always synchronous. It's also possible
to reject incoming channels before they are connected and handle channels
rejected by the peer before being fully connected.

Committed: https://crrev.com/cc40af91b15bd24efc02f82169ef1b76a5e35dbb
Cr-Commit-Position: refs/heads/master@{#407046}
==========

[commit-bot: I haz the power, 2016-07-22 03:54:45]

Patchset 2 (id:??) landed as
https://crrev.com/cc40af91b15bd24efc02f82169ef1b76a5e35dbb
Cr-Commit-Position: refs/heads/master@{#407046}