Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: remoting/protocol/webrtc_transport.h

Issue 2164163002: Simplify data channel creation logic in WebRTC-based protocol (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/webrtc_data_stream_adapter.cc ('k') | remoting/protocol/webrtc_transport.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/webrtc_transport.h
diff --git a/remoting/protocol/webrtc_transport.h b/remoting/protocol/webrtc_transport.h
index cc384cf767ca8855f053079884cc08fe368e612c..ebc5dc513a75452cb9208eb002742173409f680a 100644
--- a/remoting/protocol/webrtc_transport.h
+++ b/remoting/protocol/webrtc_transport.h
@@ -29,7 +29,6 @@ namespace remoting {
namespace protocol {
class TransportContext;
-class MessageChannelFactory;
class MessagePipe;
class WebrtcTransport : public Transport,
@@ -81,11 +80,10 @@ class WebrtcTransport : public Transport,
return video_encoder_factory_;
}
- // Factory for outgoing data channels. Must be used only after the transport
- // is connected.
- MessageChannelFactory* outgoing_channel_factory() {
- return data_stream_adapter_.get();
- }
+ // Creates outgoing data channel. The channel is created in CONNECTING state.
+ // The caller must wait for OnMessagePipeOpen() notification before sending
+ // any messages.
+ std::unique_ptr<MessagePipe> CreateOutgoingChannel(const std::string& name);
// Transport interface.
void Start(Authenticator* authenticator,
« no previous file with comments | « remoting/protocol/webrtc_data_stream_adapter.cc ('k') | remoting/protocol/webrtc_transport.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698