Simplify data channel creation logic in WebRTC-based protocol

remoting/protocol/webrtc_data_stream_adapter.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_PROTOCOL_WEBRTC_DATA_STREAM_ADAPTER_H_
 #define REMOTING_PROTOCOL_WEBRTC_DATA_STREAM_ADAPTER_H_
 
+#include <memory>
 #include <string>
 
 #include "base/callback.h"
 #include "base/macros.h"
 #include "remoting/protocol/errors.h"
 #include "remoting/protocol/message_channel_factory.h"
 #include "third_party/webrtc/api/peerconnectioninterface.h"
 #include "third_party/webrtc/base/refcount.h"
 
 namespace rtc {
 class PeerConnectionInterface;
 }  // namespace rtc
 
 namespace remoting {
 namespace protocol {
 
 // WebrtcDataStreamAdapter is a MessageChannelFactory that creates channels that

[Jamie, 2016/07/22 01:10:16]

Update the comment.

[Sergey Ulanov, 2016/07/22 01:20:37]

Done.

 // send and receive messages over PeerConnection data channels.
-class WebrtcDataStreamAdapter : public MessageChannelFactory {
+class WebrtcDataStreamAdapter {
  public:
   typedef base::Callback<void(ErrorCode)> ErrorCallback;
 
-  explicit WebrtcDataStreamAdapter(const ErrorCallback& error_callback);
-  ~WebrtcDataStreamAdapter() override;
+  WebrtcDataStreamAdapter(

[Jamie, 2016/07/22 01:10:16]

Why not explicit any more?

[Sergey Ulanov, 2016/07/22 01:20:37]

Done.

+      rtc::scoped_refptr<webrtc::PeerConnectionInterface> peer_connection);
+  ~WebrtcDataStreamAdapter();
 
-  // Initializes the adapter for |peer_connection|. If |outgoing| is set to true
-  // all channels will be created as outgoing. Otherwise CreateChannel() will
-  // wait for the other end to create connection.
-  void Initialize(
-      rtc::scoped_refptr<webrtc::PeerConnectionInterface> peer_connection);
+  // Creates outgoing data channel.
+  std::unique_ptr<MessagePipe> CreateOutgoingChannel(const std::string& name);
 
-  // Called by WebrtcTransport.
-  void WrapIncomingDataChannel(
-      rtc::scoped_refptr<webrtc::DataChannelInterface> data_channel,
-      const ChannelCreatedCallback& callback);
-
-  // MessageChannelFactory interface.
-  void CreateChannel(const std::string& name,
-                     const ChannelCreatedCallback& callback) override;
-  void CancelChannelCreation(const std::string& name) override;
+  // Creates incoming data channel.
+  std::unique_ptr<MessagePipe> WrapIncomingDataChannel(
+      rtc::scoped_refptr<webrtc::DataChannelInterface> data_channel);
 
  private:
-  class Channel;
-  friend class Channel;
-
-  struct PendingChannel;
-
-  void AddPendingChannel(
-      rtc::scoped_refptr<webrtc::DataChannelInterface> data_channel,
-      const ChannelCreatedCallback& callback);
-
-  void OnChannelConnected(Channel* channel);
-  void OnChannelError();
-
-  ErrorCallback error_callback_;
-
   rtc::scoped_refptr<webrtc::PeerConnectionInterface> peer_connection_;
 
-  std::map<std::string, PendingChannel> pending_channels_;
-
   DISALLOW_COPY_AND_ASSIGN(WebrtcDataStreamAdapter);
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_WEBRTC_DATA_STREAM_ADAPTER_H_