Remove ResourceHandler::OnBeforeNetworkStart

Remove ResourceHandler::OnBeforeNetworkStart

It's not being called, as of https://codereview.chromium.org/2123093002.
And none of the implementations actually do anything.

BUG=479994
TBR=rdsmith@chromium.org

Committed: https://crrev.com/a4afcc908811ffe8655e6c2e5a1e0c85aadd0251
Cr-Commit-Position: refs/heads/master@{#407173}

[mmenke, 2016-07-20 19:22:07]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 19:22:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 19:34:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 19:34:34]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[mmenke, 2016-07-20 19:35:45]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 19:36:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 19:52:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 19:52:04]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mmenke, 2016-07-20 19:57:06]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 19:57:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 20:40:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 20:40:01]

Dry run: This issue passed the CQ dry run.

[mmenke, 2016-07-20 20:44:50]

mmenke@chromium.org changed reviewers:
+ jkarlin@chromium.org

[mmenke, 2016-07-20 20:44:51]

Josh:  PTAL.  This touches a bunch of files, but doesn't actually do anything
except delete code that does nothing, so review shouldn't be too bad.

[jkarlin, 2016-07-21 17:10:11]

lgtm! Thanks for writing this.

[mmenke, 2016-07-21 17:25:28]

mmenke@chromium.org changed reviewers:
+ jam@chromium.org, rdsmith@chromium.org

[mmenke, 2016-07-21 17:25:29]

[+jam]:  Please review 	content/public/browser/resource_throttle.h (Removing an
unused method)
[+rdsmith]:  Please review chrome/browser/download/ (Removing code that does
nothing)

[jam, 2016-07-21 22:36:27]

On 2016/07/21 17:25:29, mmenke wrote:
> [+jam]:  Please review 	content/public/browser/resource_throttle.h (Removing
an
> unused method)
lgtm

[mmenke, 2016-07-22 15:05:26]

On 2016/07/21 22:36:27, jam wrote:
> On 2016/07/21 17:25:29, mmenke wrote:
> > [+jam]:  Please review 	content/public/browser/resource_throttle.h (Removing
> an
> > unused method)
> lgtm

Going to go ahead and TBR rdsmith - he's off next week, out today, and asanka's
on leave.  As I'm just removing a method the download's code didn't use to do
anything when trimming down an API, TBR seems reasonable.

[mmenke, 2016-07-22 15:05:41]

Description was changed from

==========
Remove ResourceHandler::OnBeforeNetworkStart

It's not being called, as of https://codereview.chromium.org/2123093002.
And none of the implementations actually do anything.

BUG=479994
==========

to

==========
Remove ResourceHandler::OnBeforeNetworkStart

It's not being called, as of https://codereview.chromium.org/2123093002.
And none of the implementations actually do anything.

BUG=479994
TBR=rdsmith@chromium.org
==========

[mmenke, 2016-07-22 15:05:50]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2016-07-22 15:06:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 16:36:42]

Description was changed from

==========
Remove ResourceHandler::OnBeforeNetworkStart

It's not being called, as of https://codereview.chromium.org/2123093002.
And none of the implementations actually do anything.

BUG=479994
TBR=rdsmith@chromium.org
==========

to

==========
Remove ResourceHandler::OnBeforeNetworkStart

It's not being called, as of https://codereview.chromium.org/2123093002.
And none of the implementations actually do anything.

BUG=479994
TBR=rdsmith@chromium.org
==========

[commit-bot: I haz the power, 2016-07-22 16:36:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-22 16:38:35]

Description was changed from

==========
Remove ResourceHandler::OnBeforeNetworkStart

It's not being called, as of https://codereview.chromium.org/2123093002.
And none of the implementations actually do anything.

BUG=479994
TBR=rdsmith@chromium.org
==========

to

==========
Remove ResourceHandler::OnBeforeNetworkStart

It's not being called, as of https://codereview.chromium.org/2123093002.
And none of the implementations actually do anything.

BUG=479994
TBR=rdsmith@chromium.org

Committed: https://crrev.com/a4afcc908811ffe8655e6c2e5a1e0c85aadd0251
Cr-Commit-Position: refs/heads/master@{#407173}
==========

[commit-bot: I haz the power, 2016-07-22 16:38:36]

Patchset 3 (id:??) landed as
https://crrev.com/a4afcc908811ffe8655e6c2e5a1e0c85aadd0251
Cr-Commit-Position: refs/heads/master@{#407173}