Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2123093002:
Remove URLRequest::Delegate::OnBeforeNetworkStart. (Closed)
|
Created:
4 years, 5 months ago by maksims (do not use this acc) Modified:
4 years, 5 months ago CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, cbentzel+watch_chromium.org, tzik, serviceworker-reviews, jam, Randy Smith (Not in Mondays), nhiroki, blink-worker-reviews_chromium.org, darin-cc_chromium.org, jkarlin+watch_chromium.org, horo+watch_chromium.org, loading-reviews_chromium.org, kinuko+serviceworker, kinuko+watch, mmenke Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove URLRequest::Delegate::OnBeforeNetworkStart.
URLRequest::Delegate::OnBeforeNetworkStart is not used by
anything, despite having a lot of plumping. It was added to
try experimenting with having the ResourceScheduler delay
requests only once they needed to go over the network, so
responses that could be served out of the cache.
BUG=479994
Committed: https://crrev.com/0af4009f7ce7a5a00091070e85bfd36745bba02c
Committed: https://crrev.com/19b0189b80e2bc53b63000de2f44d37479a13abc
Cr-Original-Commit-Position: refs/heads/master@{#404606}
Cr-Commit-Position: refs/heads/master@{#405088}
Patch Set 1 #Patch Set 2 : remove commented out unittest #Messages
Total messages: 30 (18 generated)
Description was changed from ========== Remove OnBeforeNetworkStart BUG= ========== to ========== Remove OnBeforeNetworkStart BUG= ==========
maksim.sisov@intel.com changed reviewers: + mmenke@chromium.org
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Description was changed from ========== Remove OnBeforeNetworkStart BUG= ========== to ========== Remove URLRequest::Delegate::OnBeforeNetworkStart URLRequest::Delegate::OnBeforeNetworkStart is not used by anything, despite having a lot of plumping. It was added to try experimenting with having the ResourceScheduler delay requests only once they needed to go over the network, so responses that could be served out of the cache. BUG=479994 ==========
Description was changed from ========== Remove URLRequest::Delegate::OnBeforeNetworkStart URLRequest::Delegate::OnBeforeNetworkStart is not used by anything, despite having a lot of plumping. It was added to try experimenting with having the ResourceScheduler delay requests only once they needed to go over the network, so responses that could be served out of the cache. BUG=479994 ========== to ========== Remove URLRequest::Delegate::OnBeforeNetworkStart. URLRequest::Delegate::OnBeforeNetworkStart is not used by anything, despite having a lot of plumping. It was added to try experimenting with having the ResourceScheduler delay requests only once they needed to go over the network, so responses that could be served out of the cache. BUG=479994 ==========
please take a look once back
maksim.sisov@intel.com changed reviewers: + jam@chromium.org, rdsmith@chromium.org
+ jam@, + rdsmith@
lgtm
The CQ bit was checked by maksim.sisov@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove URLRequest::Delegate::OnBeforeNetworkStart. URLRequest::Delegate::OnBeforeNetworkStart is not used by anything, despite having a lot of plumping. It was added to try experimenting with having the ResourceScheduler delay requests only once they needed to go over the network, so responses that could be served out of the cache. BUG=479994 ========== to ========== Remove URLRequest::Delegate::OnBeforeNetworkStart. URLRequest::Delegate::OnBeforeNetworkStart is not used by anything, despite having a lot of plumping. It was added to try experimenting with having the ResourceScheduler delay requests only once they needed to go over the network, so responses that could be served out of the cache. BUG=479994 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:60001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Remove URLRequest::Delegate::OnBeforeNetworkStart. URLRequest::Delegate::OnBeforeNetworkStart is not used by anything, despite having a lot of plumping. It was added to try experimenting with having the ResourceScheduler delay requests only once they needed to go over the network, so responses that could be served out of the cache. BUG=479994 ========== to ========== Remove URLRequest::Delegate::OnBeforeNetworkStart. URLRequest::Delegate::OnBeforeNetworkStart is not used by anything, despite having a lot of plumping. It was added to try experimenting with having the ResourceScheduler delay requests only once they needed to go over the network, so responses that could be served out of the cache. BUG=479994 Committed: https://crrev.com/0af4009f7ce7a5a00091070e85bfd36745bba02c Cr-Commit-Position: refs/heads/master@{#404606} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0af4009f7ce7a5a00091070e85bfd36745bba02c Cr-Commit-Position: refs/heads/master@{#404606}
Message was sent while issue was closed.
Description was changed from ========== Remove URLRequest::Delegate::OnBeforeNetworkStart. URLRequest::Delegate::OnBeforeNetworkStart is not used by anything, despite having a lot of plumping. It was added to try experimenting with having the ResourceScheduler delay requests only once they needed to go over the network, so responses that could be served out of the cache. BUG=479994 Committed: https://crrev.com/0af4009f7ce7a5a00091070e85bfd36745bba02c Cr-Commit-Position: refs/heads/master@{#404606} ========== to ========== Remove URLRequest::Delegate::OnBeforeNetworkStart. URLRequest::Delegate::OnBeforeNetworkStart is not used by anything, despite having a lot of plumping. It was added to try experimenting with having the ResourceScheduler delay requests only once they needed to go over the network, so responses that could be served out of the cache. BUG=479994 Committed: https://crrev.com/0af4009f7ce7a5a00091070e85bfd36745bba02c Cr-Commit-Position: refs/heads/master@{#404606} ==========
The CQ bit was checked by maksim.sisov@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org Link to the patchset: https://codereview.chromium.org/2123093002/#ps80001 (title: "remove commented out unittest")
The CQ bit was unchecked by maksim.sisov@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by maksim.sisov@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove URLRequest::Delegate::OnBeforeNetworkStart. URLRequest::Delegate::OnBeforeNetworkStart is not used by anything, despite having a lot of plumping. It was added to try experimenting with having the ResourceScheduler delay requests only once they needed to go over the network, so responses that could be served out of the cache. BUG=479994 Committed: https://crrev.com/0af4009f7ce7a5a00091070e85bfd36745bba02c Cr-Commit-Position: refs/heads/master@{#404606} ========== to ========== Remove URLRequest::Delegate::OnBeforeNetworkStart. URLRequest::Delegate::OnBeforeNetworkStart is not used by anything, despite having a lot of plumping. It was added to try experimenting with having the ResourceScheduler delay requests only once they needed to go over the network, so responses that could be served out of the cache. BUG=479994 Committed: https://crrev.com/0af4009f7ce7a5a00091070e85bfd36745bba02c Cr-Commit-Position: refs/heads/master@{#404606} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:80001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Remove URLRequest::Delegate::OnBeforeNetworkStart. URLRequest::Delegate::OnBeforeNetworkStart is not used by anything, despite having a lot of plumping. It was added to try experimenting with having the ResourceScheduler delay requests only once they needed to go over the network, so responses that could be served out of the cache. BUG=479994 Committed: https://crrev.com/0af4009f7ce7a5a00091070e85bfd36745bba02c Cr-Commit-Position: refs/heads/master@{#404606} ========== to ========== Remove URLRequest::Delegate::OnBeforeNetworkStart. URLRequest::Delegate::OnBeforeNetworkStart is not used by anything, despite having a lot of plumping. It was added to try experimenting with having the ResourceScheduler delay requests only once they needed to go over the network, so responses that could be served out of the cache. BUG=479994 Committed: https://crrev.com/0af4009f7ce7a5a00091070e85bfd36745bba02c Committed: https://crrev.com/19b0189b80e2bc53b63000de2f44d37479a13abc Cr-Original-Commit-Position: refs/heads/master@{#404606} Cr-Commit-Position: refs/heads/master@{#405088} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/19b0189b80e2bc53b63000de2f44d37479a13abc Cr-Commit-Position: refs/heads/master@{#405088} |
