content/browser/loader/mime_type_resource_handler_unittest.cc - Issue 2164113002: Remove ResourceHandler::OnBeforeNetworkStart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/mime_type_resource_handler_unittest.cc

Issue 2164113002: Remove ResourceHandler::OnBeforeNetworkStart (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Oops Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/loader/mime_type_resource_handler_unittest.cc

diff --git a/content/browser/loader/mime_type_resource_handler_unittest.cc b/content/browser/loader/mime_type_resource_handler_unittest.cc

index 6bed3a84943e687afdae7da24ee34929042361b8..8c6f6e35c96c575810c2485aa536be93ad599e42 100644

--- a/content/browser/loader/mime_type_resource_handler_unittest.cc

+++ b/content/browser/loader/mime_type_resource_handler_unittest.cc

@@ -52,11 +52,6 @@ class TestResourceHandler : public ResourceHandler {

return false;

}

- bool OnBeforeNetworkStart(const GURL& url, bool* defer) override {

- NOTREACHED();

- return false;

- }

bool OnWillRead(scoped_refptr<net::IOBuffer>* buf,

int* buf_size,

int min_size) override {