third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js - Issue 2163803002: [DevTools] Make WebInspector.ConsoleMessage 0-based

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

Issue 2163803002: [DevTools] Make WebInspector.ConsoleMessage 0-based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-log-syntax-error-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js b/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

index 4be676387f67115174b826a83c52e9ab15c6cd7a..dafe5231b86d811ed7385eb1fbe31d6da67a1a34 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

@@ -87,9 +87,8 @@ WebInspector.PresentationConsoleMessageHelper.prototype = {

if (!debuggerModel)

return null;

var callFrame = message.stackTrace && message.stackTrace.callFrames ? message.stackTrace.callFrames[0] : null;

- // FIXME(62725): stack trace line/column numbers are one-based.

- var lineNumber = callFrame ? callFrame.lineNumber : message.line - 1;

- var columnNumber = message.column ? message.column - 1 : 0;

+ var lineNumber = callFrame ? callFrame.lineNumber : message.line;

+ var columnNumber = callFrame ? callFrame.columnNumber : message.column;

if (callFrame)

columnNumber = callFrame.columnNumber;

if (message.scriptId)