third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js - Issue 2163803002: [DevTools] Make WebInspector.ConsoleMessage 0-based

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

Issue 2163803002: [DevTools] Make WebInspector.ConsoleMessage 0-based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js ('k') | third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

index d80d6b71facc4354f0735d7405b851bad238a712..af7b609f54c10b56a37d082a5580a502375af7fb 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

@@ -376,8 +376,8 @@ WebInspector.RuntimeDispatcher.prototype = {

details.text,

undefined,

details.url,

- details.lineNumber + 1,

- details.columnNumber + 1,

+ details.lineNumber,

+ details.columnNumber,

undefined,

exception ? ["Uncaught (in promise)", exception] : undefined,

details.stackTrace,

@@ -446,8 +446,8 @@ WebInspector.RuntimeDispatcher.prototype = {

/** @type {string} */ (message),

type,

callFrame ? callFrame.url : undefined,

- callFrame ? callFrame.lineNumber + 1 : undefined,

- callFrame ? callFrame.columnNumber + 1 : undefined,

+ callFrame ? callFrame.lineNumber : undefined,

+ callFrame ? callFrame.columnNumber : undefined,

undefined,

args,

stackTrace,