Linux: Build with xcb (Reland)

Linux: Build with xcb

BUG=634085
Committed: https://crrev.com/f05e88ae004f438fcd8fb2023b51ba19a7903e48
Cr-Commit-Position: refs/heads/master@{#414882}

[Tom (Use chromium acct), 2016-07-19 23:53:19]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 23:54:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 00:11:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 00:11:13]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Dirk Pranke, 2016-07-28 21:52:35]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org, mmoss@chromium.org, thestig@chromium.org

[Tom (Use chromium acct), 2016-07-28 23:25:40]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 23:26:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 23:36:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 23:36:55]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Lei Zhang, 2016-07-29 00:58:18]

This doesn't work as is. You need multiple CLs:

- One CL to update the sysroot

[upload the new sysroot tarballs]

- Second CL to switch to the sysroot
- Third CL to start using features from the new sysroot. (This can be part of
the previous CL, but it might be better to take things one step at a time)

[Tom (Use chromium acct), 2016-08-02 01:26:38]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 01:26:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 05:28:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 05:28:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Tom (Use chromium acct), 2016-08-02 20:24:56]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 20:25:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 21:48:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 21:48:42]

Dry run: This issue passed the CQ dry run.

[Tom (Use chromium acct), 2016-08-02 22:37:33]

Description was changed from

==========
Try adding xcb
==========

to

==========
Linux: Build with xcb
==========

[Dirk Pranke, 2016-08-03 00:12:34]

lgtm.

When this lands, you'll probably need to have the labs folks re-run
build/install-build-deps.sh on all of the linux machines ...

[Lei Zhang, 2016-08-03 19:08:07]

On 2016/08/03 00:12:34, Dirk Pranke wrote:
> lgtm.
> 
> When this lands, you'll probably need to have the labs folks re-run
> build/install-build-deps.sh on all of the linux machines ...

How about landing the install-build-deps changes separately first, re-run it on
all the machines, and land the rest?

Also, BUG= ?

[Lei Zhang, 2016-08-03 19:08:53]

https://codereview.chromium.org/2163623003/diff/60001/build/install-build-dep...
File build/install-build-deps.sh (right):

https://codereview.chromium.org/2163623003/diff/60001/build/install-build-dep...
build/install-build-deps.sh:131: zlib1g $chromeos_lib_list libx11-xcb1"
alphabetical order, ditto below.

[Tom (Use chromium acct), 2016-08-03 19:31:56]

Description was changed from

==========
Linux: Build with xcb
==========

to

==========
Linux: Build with xcb

BUG=634085
==========

[Tom (Use chromium acct), 2016-08-03 19:38:34]

On 2016/08/03 19:08:07, Lei Zhang wrote:
> On 2016/08/03 00:12:34, Dirk Pranke wrote:
> > lgtm.
> > 
> > When this lands, you'll probably need to have the labs folks re-run
> > build/install-build-deps.sh on all of the linux machines ...
> 
> How about landing the install-build-deps changes separately first, re-run it
on
> all the machines, and land the rest?

I think the linux machines already have the necessary dependencies installed.
I picked a try server and it has these packages already:
libxcb1:amd64                       1.10-2ubuntu1
libx11-xcb1:amd64                   2:1.6.2-1ubuntu2

> 
> Also, BUG= ?

Added BUG.

[Tom (Use chromium acct), 2016-08-03 19:42:15]

thomasanderson@google.com changed reviewers:
+ sadrul@chromium.org
- mmoss@chromium.org

[Tom (Use chromium acct), 2016-08-03 19:42:16]

+sadrul for ui/gfx/x

https://codereview.chromium.org/2163623003/diff/60001/build/install-build-dep...
File build/install-build-deps.sh (right):

https://codereview.chromium.org/2163623003/diff/60001/build/install-build-dep...
build/install-build-deps.sh:131: zlib1g $chromeos_lib_list libx11-xcb1"
On 2016/08/03 19:08:52, Lei Zhang wrote:
> alphabetical order, ditto below.

Done.

https://codereview.chromium.org/2163623003/diff/80001/ui/gfx/x/x11_types.cc
File ui/gfx/x/x11_types.cc (left):

https://codereview.chromium.org/2163623003/diff/80001/ui/gfx/x/x11_types.cc#o...
ui/gfx/x/x11_types.cc:176: 
emacs auto-saves the file like this

https://codereview.chromium.org/2163623003/diff/80001/ui/gfx/x/x11_types.cc
File ui/gfx/x/x11_types.cc (right):

https://codereview.chromium.org/2163623003/diff/80001/ui/gfx/x/x11_types.cc#n...
ui/gfx/x/x11_types.cc:21: asm volatile("" ::"r"(xcb_connect));
Couldn't figure out a better way to do this

[Tom (Use chromium acct), 2016-08-03 19:42:27]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 19:42:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 21:25:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 21:25:06]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-08-04 15:45:29]

https://codereview.chromium.org/2163623003/diff/80001/ui/gfx/x/x11_types.cc
File ui/gfx/x/x11_types.cc (right):

https://codereview.chromium.org/2163623003/diff/80001/ui/gfx/x/x11_types.cc#n...
ui/gfx/x/x11_types.cc:21: asm volatile("" ::"r"(xcb_connect));
On 2016/08/03 19:42:16, Tom Anderson wrote:
> Couldn't figure out a better way to do this

What does this do?

[Tom (Use chromium acct), 2016-08-04 16:32:53]

https://codereview.chromium.org/2163623003/diff/80001/ui/gfx/x/x11_types.cc
File ui/gfx/x/x11_types.cc (right):

https://codereview.chromium.org/2163623003/diff/80001/ui/gfx/x/x11_types.cc#n...
ui/gfx/x/x11_types.cc:21: asm volatile("" ::"r"(xcb_connect));
On 2016/08/04 15:45:29, sadrul wrote:
> On 2016/08/03 19:42:16, Tom Anderson wrote:
> > Couldn't figure out a better way to do this
> 
> What does this do?

References symbols so we link against the shared libraries and the dependencies
show up in expected_build_deps.

I wanted all of the build stuff to go in one cl, but maybe the
expected_build_deps stuff should just go in the next one that actually uses xcb?

[Lei Zhang, 2016-08-04 22:08:06]

https://codereview.chromium.org/2163623003/diff/80001/chrome/installer/linux/...
File chrome/installer/linux/debian/expected_deps_x64 (right):

https://codereview.chromium.org/2163623003/diff/80001/chrome/installer/linux/...
chrome/installer/linux/debian/expected_deps_x64:7: libdbus-1-3 (>= 1.2.14)
Did you build with "allow_posix_link_time_opt = false" in your official build? I
think that might be why this value is different for you.

[Tom (Use chromium acct), 2016-08-04 22:54:28]

Patchset #8 (id:140001) has been deleted

[Tom (Use chromium acct), 2016-08-04 22:56:23]

https://codereview.chromium.org/2163623003/diff/80001/chrome/installer/linux/...
File chrome/installer/linux/debian/expected_deps_x64 (right):

https://codereview.chromium.org/2163623003/diff/80001/chrome/installer/linux/...
chrome/installer/linux/debian/expected_deps_x64:7: libdbus-1-3 (>= 1.2.14)
On 2016/08/04 22:08:06, Lei Zhang wrote:
> Did you build with "allow_posix_link_time_opt = false" in your official build?
I
> think that might be why this value is different for you.

Yes I did.  Removed!

Also reverted all of the expected_deps files so we can just update them when we
actually start using xcb and need to link against it.

[Lei Zhang, 2016-08-04 22:59:13]

If this works, then go for it.

[Tom (Use chromium acct), 2016-08-04 23:02:30]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 23:02:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 01:06:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 01:06:27]

Dry run: This issue passed the CQ dry run.

[Tom (Use chromium acct), 2016-08-09 03:02:03]

On 2016/08/04 22:59:13, Lei Zhang wrote:
> If this works, then go for it.

install-build-deps.sh has been rerun on the build slaves
https://bugs.chromium.org/p/chromium/issues/detail?id=635014

sadrul@ + thestig@ I still need your OWNERS approval

[Lei Zhang, 2016-08-09 05:10:45]

lgtm

[Tom (Use chromium acct), 2016-08-09 05:30:29]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2016-08-09 05:30:30]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2163623003/#ps120001
(title: "Revert all expected_deps*")

[commit-bot: I haz the power, 2016-08-09 05:30:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 05:37:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 05:37:05]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sadrul, 2016-08-09 16:12:30]

https://codereview.chromium.org/2163623003/diff/120001/ui/base/x/BUILD.gn
File ui/base/x/BUILD.gn (right):

https://codereview.chromium.org/2163623003/diff/120001/ui/base/x/BUILD.gn#new...
ui/base/x/BUILD.gn:22: "//build/config/linux:xcb",
Do you actually need the new configs?

[Tom (Use chromium acct), 2016-08-09 16:43:45]

On 2016/08/09 16:12:30, sadrul wrote:
> https://codereview.chromium.org/2163623003/diff/120001/ui/base/x/BUILD.gn
> File ui/base/x/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2163623003/diff/120001/ui/base/x/BUILD.gn#new...
> ui/base/x/BUILD.gn:22: "//build/config/linux:xcb",
> Do you actually need the new configs?

I need them for a future patch set.  Should I just move the ui/base/x/ one to
the other patch?
Haha, if you look at patch set 1, you'll see that this change is slowly turning
into nothing because everything is getting split off :P

[sadrul, 2016-08-09 16:47:35]

On 2016/08/09 16:43:45, Tom Anderson wrote:
> On 2016/08/09 16:12:30, sadrul wrote:
> > https://codereview.chromium.org/2163623003/diff/120001/ui/base/x/BUILD.gn
> > File ui/base/x/BUILD.gn (right):
> > 
> >
>
https://codereview.chromium.org/2163623003/diff/120001/ui/base/x/BUILD.gn#new...
> > ui/base/x/BUILD.gn:22: "//build/config/linux:xcb",
> > Do you actually need the new configs?
> 
> I need them for a future patch set.  Should I just move the ui/base/x/ one to
> the other patch?
> Haha, if you look at patch set 1, you'll see that this change is slowly
turning
> into nothing because everything is getting split off :P

What I mean is, you have updated the X11 config to already pull in X11-xcb and
xcb. In that case, do we need the separate x11-xcb and xcb configs?

[Tom (Use chromium acct), 2016-08-09 19:18:25]

On 2016/08/09 16:47:35, sadrul wrote:
> On 2016/08/09 16:43:45, Tom Anderson wrote:
> > On 2016/08/09 16:12:30, sadrul wrote:
> > > https://codereview.chromium.org/2163623003/diff/120001/ui/base/x/BUILD.gn
> > > File ui/base/x/BUILD.gn (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2163623003/diff/120001/ui/base/x/BUILD.gn#new...
> > > ui/base/x/BUILD.gn:22: "//build/config/linux:xcb",
> > > Do you actually need the new configs?
> > 
> > I need them for a future patch set.  Should I just move the ui/base/x/ one
to
> > the other patch?
> > Haha, if you look at patch set 1, you'll see that this change is slowly
> turning
> > into nothing because everything is getting split off :P
> 
> What I mean is, you have updated the X11 config to already pull in X11-xcb and
> xcb. In that case, do we need the separate x11-xcb and xcb configs?

Done.  Thanks for catching that

[Tom (Use chromium acct), 2016-08-09 19:18:32]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2016-08-09 19:18:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2163623003/#ps180001
(title: "Revert gyp configs :D")

[commit-bot: I haz the power, 2016-08-09 19:19:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 20:42:54]

Description was changed from

==========
Linux: Build with xcb

BUG=634085
==========

to

==========
Linux: Build with xcb

BUG=634085
==========

[commit-bot: I haz the power, 2016-08-09 20:42:56]

Committed patchset #9 (id:180001)

[commit-bot: I haz the power, 2016-08-09 20:45:15]

Description was changed from

==========
Linux: Build with xcb

BUG=634085
==========

to

==========
Linux: Build with xcb

BUG=634085

Committed: https://crrev.com/83b8989c96b207efd9123cd25073b32edfe5a275
Cr-Commit-Position: refs/heads/master@{#410806}
==========

[commit-bot: I haz the power, 2016-08-09 20:45:17]

Patchset 9 (id:??) landed as
https://crrev.com/83b8989c96b207efd9123cd25073b32edfe5a275
Cr-Commit-Position: refs/heads/master@{#410806}

[Tom (Use chromium acct), 2016-08-09 21:05:07]

A revert of this CL (patchset #9 id:180001) has been created in
https://codereview.chromium.org/2229663006/ by thomasanderson@google.com.

The reason for reverting is: Causing build failure

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
../../third_party/binutils/Linux_x64/Release/bin/ld.gold: error: cannot find
-lX11-xcb.

[Tom (Use chromium acct), 2016-08-10 23:17:11]

Description was changed from

==========
Linux: Build with xcb

BUG=634085

Committed: https://crrev.com/83b8989c96b207efd9123cd25073b32edfe5a275
Cr-Commit-Position: refs/heads/master@{#410806}
==========

to

==========
Linux: Build with xcb

BUG=634085

Committed: https://crrev.com/83b8989c96b207efd9123cd25073b32edfe5a275
Cr-Commit-Position: refs/heads/master@{#410806}
==========

[Tom (Use chromium acct), 2016-08-10 23:19:40]

On 2016/08/09 21:05:07, Tom Anderson wrote:
> A revert of this CL (patchset #9 id:180001) has been created in
> https://codereview.chromium.org/2229663006/ by
mailto:thomasanderson@google.com.
> 
> The reason for reverting is: Causing build failure
> 
>
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
> ../../third_party/binutils/Linux_x64/Release/bin/ld.gold: error: cannot find
> -lX11-xcb.

Going to try to reland this.
Reason for failure: couldn't link xdisplaycheck on ChromeOS
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
The log indicates xdisplaycheck didn't link against the sysroot, but was using
the system libraries.  However, xdisplaycheck linked on the ChromeOS try bots,
and I see that it does use the sysroot if I try to build locally.

[Tom (Use chromium acct), 2016-08-10 23:19:49]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2016-08-10 23:20:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 02:03:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 02:03:01]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Tom (Use chromium acct), 2016-08-11 16:44:11]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2016-08-11 16:44:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom (Use chromium acct), 2016-08-11 18:02:51]

The CQ bit was unchecked by thomasanderson@google.com

[sadrul, 2016-08-12 15:13:19]

sadrul@chromium.org changed reviewers:
- sadrul@chromium.org

[sadrul, 2016-08-12 15:13:20]

Removing myself from the reviewer list since my review is no longer needed.

[Tom (Use chromium acct), 2016-08-17 01:15:08]

Description was changed from

==========
Linux: Build with xcb

BUG=634085

Committed: https://crrev.com/83b8989c96b207efd9123cd25073b32edfe5a275
Cr-Commit-Position: refs/heads/master@{#410806}
==========

to

==========
Linux: Build with xcb

BUG=634085
==========

[Tom (Use chromium acct), 2016-08-25 22:48:08]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2016-08-25 22:48:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2163623003/#ps200001
(title: "Revert install-sysroot.py")

[commit-bot: I haz the power, 2016-08-25 22:49:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom (Use chromium acct), 2016-08-26 00:28:16]

The CQ bit was unchecked by thomasanderson@google.com

[Tom (Use chromium acct), 2016-08-27 00:03:40]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2016-08-27 00:04:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 01:33:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-27 01:33:15]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Tom (Use chromium acct), 2016-08-27 01:34:24]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-27 01:34:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 02:04:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-27 02:04:43]

Dry run: This issue passed the CQ dry run.

[Tom (Use chromium acct), 2016-08-27 02:05:07]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2016-08-27 02:05:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 10:23:10]

Description was changed from

==========
Linux: Build with xcb

BUG=634085
==========

to

==========
Linux: Build with xcb

BUG=634085
==========

[commit-bot: I haz the power, 2016-08-27 10:23:11]

Committed patchset #10 (id:200001)

[commit-bot: I haz the power, 2016-08-27 10:25:38]

Description was changed from

==========
Linux: Build with xcb

BUG=634085
==========

to

==========
Linux: Build with xcb

BUG=634085

Committed: https://crrev.com/f05e88ae004f438fcd8fb2023b51ba19a7903e48
Cr-Commit-Position: refs/heads/master@{#414882}
==========

[commit-bot: I haz the power, 2016-08-27 10:25:40]

Patchset 10 (id:??) landed as
https://crrev.com/f05e88ae004f438fcd8fb2023b51ba19a7903e48
Cr-Commit-Position: refs/heads/master@{#414882}