Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2229663006: Revert of Linux: Build with xcb (Closed)

Created:
4 years, 4 months ago by Tom (Use chromium acct)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Linux: Build with xcb (patchset #9 id:180001 of https://codereview.chromium.org/2163623003/ ) Reason for revert: Causing build failure https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/49862/steps/compile/logs/stdio ../../third_party/binutils/Linux_x64/Release/bin/ld.gold: error: cannot find -lX11-xcb Original issue's description: > Linux: Build with xcb > > BUG=634085 > > Committed: https://crrev.com/83b8989c96b207efd9123cd25073b32edfe5a275 > Cr-Commit-Position: refs/heads/master@{#410806} TBR=thestig@chromium.org,dpranke@chromium.org,sadrul@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=634085 Committed: https://crrev.com/6d2d93120d8f4b78671bc62674005b4c03995f85 Cr-Commit-Position: refs/heads/master@{#410820}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M build/config/linux/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M build/linux/sysroot_scripts/install-sysroot.py View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Tom (Use chromium acct)
Created Revert of Linux: Build with xcb
4 years, 4 months ago (2016-08-09 21:05:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229663006/1
4 years, 4 months ago (2016-08-09 21:05:57 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-09 21:06:00 UTC) #5
Elliot Glaysher
lgtm
4 years, 4 months ago (2016-08-09 21:10:45 UTC) #7
cbiesinger
lgtm
4 years, 4 months ago (2016-08-09 21:10:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229663006/1
4 years, 4 months ago (2016-08-09 21:11:45 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 21:12:27 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 21:13:38 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d2d93120d8f4b78671bc62674005b4c03995f85
Cr-Commit-Position: refs/heads/master@{#410820}

Powered by Google App Engine
This is Rietveld 408576698