Linux: Build with xcb (Reland)

ui/gfx/x/x11_types.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/x/x11_types.h"
 
 #include <X11/Xlib.h>
+#include <xcb/xcb.h>
+#include <X11/Xlib-xcb.h>
 
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "build/build_config.h"
 #include "ui/gfx/x/x11_switches.h"
 
 namespace gfx {
 
 XDisplay* GetXDisplay() {
+  // TODO(thomasanderson): remove these symbol references once libxcb and
+  // libX11-xcb are used
+  asm volatile("" ::"r"(xcb_connect));

[Tom (Use chromium acct), 2016/08/03 19:42:16]

Couldn't figure out a better way to do this

[sadrul, 2016/08/04 15:45:29]

What does this do?

[Tom (Use chromium acct), 2016/08/04 16:32:53]

References symbols so we link against the shared libraries and the dependencies
show up in expected_build_deps.

I wanted all of the build stuff to go in one cl, but maybe the
expected_build_deps stuff should just go in the next one that actually uses xcb?

+  asm volatile("" ::"r"(XGetXCBConnection));
   static XDisplay* display = NULL;
   if (!display)
     display = OpenNewXDisplay();
   return display;
 }
 
 XDisplay* OpenNewXDisplay() {
 #if defined(OS_CHROMEOS)
   return XOpenDisplay(NULL);
 #else
@@ skipping 139 matching lines @@
               copy_width, copy_height);
     free(orig_bitmap16);
   } else {
     LOG(FATAL) << "Sorry, we don't support your visual depth without "
                   "Xrender support (depth:" << depth
                << " bpp:" << pixmap_bpp << ")";
   }
 }
 
 }  // namespace gfx
-

[Tom (Use chromium acct), 2016/08/03 19:42:16]

emacs auto-saves the file like this