Issue 2163583002: Revert of [Telemetry] Ensure that story display names are unique

Issue 2163583002: Revert of [Telemetry] Ensure that story display names are unique (Closed)

Created:
4 years, 5 months ago by eakuefner

Modified:
4 years, 5 months ago

Reviewers:
nednguyen

CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org

Base URL:
git@github.com:catapult-project/catapult.git@master

Target Ref:
refs/heads/master

Project:
catapult

Visibility:
Public.

Revert of [Telemetry] Ensure that story display names are unique (patchset #3 id:40001 of https://codereview.chromium.org/2153513002/ ) Reason for revert: Broke telemetry_perf_unittests: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/264843 Original issue's description: > [Telemetry] Ensure that story display names are unique > > Telemetry operates on a de-facto assumption that story display names are > unique; this CL makes it de-jure. > > BUG=catapult:#2429 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/42560ff37c155a0b8c319f79511154f58c465b34 TBR=nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=catapult:#2429 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/7aeded9c4ce9106b93c5e27f32315cf104f30c4e

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -73 lines)			Patch
M	telemetry/telemetry/internal/story_runner_unittest.py	View	8 chunks	+18 lines, -19 lines	0 comments	Download
M	telemetry/telemetry/page/page_run_end_to_end_unittest.py	View	3 chunks	+7 lines, -12 lines	0 comments	Download
M	telemetry/telemetry/story/story_set.py	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	telemetry/telemetry/story/story_set_unittest.py	View	2 chunks	+2 lines, -33 lines	0 comments	Download

Total messages: 5 (2 generated)

eakuefner

Created Revert of [Telemetry] Ensure that story display names are unique

4 years, 5 months ago (2016-07-19 06:28:06 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163583002/1

4 years, 5 months ago (2016-07-19 06:28:16 UTC) #3

commit-bot: I haz the power

4 years, 5 months ago (2016-07-19 06:28:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...