Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1314)

Unified Diff: telemetry/telemetry/story/story_set.py

Issue 2163583002: Revert of [Telemetry] Ensure that story display names are unique (Closed) Base URL: git@github.com:catapult-project/catapult.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/story/story_set.py
diff --git a/telemetry/telemetry/story/story_set.py b/telemetry/telemetry/story/story_set.py
index 4b41f06043182ff818c9e6051f38d867db0a7d7e..667cbd01ebb7b9b3114da16ae16933335b97f9ef 100644
--- a/telemetry/telemetry/story/story_set.py
+++ b/telemetry/telemetry/story/story_set.py
@@ -98,16 +98,7 @@
def AddStory(self, story):
assert isinstance(story, story_module.Story)
- assert self._IsUnique(story), ('Tried to add story with duplicate display '
- 'name %s. Story display names should be '
- 'unique.' % story.display_name)
self.stories.append(story)
-
- def _IsUnique(self, story):
- return not any((story.display_name == other.display_name) and
- sorted(story.grouping_keys.iteritems()) ==
- sorted(other.grouping_keys.iteritems())
- for other in self.stories)
def RemoveStory(self, story):
"""Removes a Story.
« no previous file with comments | « telemetry/telemetry/page/page_run_end_to_end_unittest.py ('k') | telemetry/telemetry/story/story_set_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698