Allow rounding errors in Site Engagement tests

Allow rounding errors in Site Engagement tests

This change alters SiteEngagement tests to allow for
small rounding errors.
This will allow Qualcom chipsets to pass those tests, which
are often off by minimal values.

BUG=629844
Committed: https://crrev.com/ca9d8ac0a8735dacad863962c28a960c60747042
Cr-Commit-Position: refs/heads/master@{#406785}

[kraush, 2016-07-20 15:08:47]

kraush@amazon.com changed reviewers:
+ benwells@chromium.org

[kraush, 2016-07-20 15:08:48]

Hi benwells,

Can you take a look at this test fix for Qualcom devices?

Thanks! :)
Holger

[benwells, 2016-07-21 02:11:34]

lgtm.

Do you have a plan to stop this happening more generally? E.g. maybe ASSERT_EQ
on a double should give a compile error.

[kraush, 2016-07-21 05:48:13]

On 2016/07/21 02:11:34, benwells wrote:
> lgtm.
> 
> Do you have a plan to stop this happening more generally? E.g. maybe ASSERT_EQ
> on a double should give a compile error.

I did consider changing EXPECT_DOUBLE_EQ to be more lenient.
However, I'm not sure how universally accepted such a change would be.
Do you think it is feasible? (Or embedding it in EXPECT/ASSERT_EQ directly as
you suggested)

[kraush, 2016-07-21 05:48:17]

The CQ bit was checked by kraush@amazon.com

[commit-bot: I haz the power, 2016-07-21 05:48:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 06:26:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-21 06:27:55]

Description was changed from

==========
Allow rounding errors in Site Engagement tests

This change alters SiteEngagement tests to allow for
small rounding errors.
This will allow Qualcom chipsets to pass those tests, which
are often off by minimal values.

BUG=629844
==========

to

==========
Allow rounding errors in Site Engagement tests

This change alters SiteEngagement tests to allow for
small rounding errors.
This will allow Qualcom chipsets to pass those tests, which
are often off by minimal values.

BUG=629844

Committed: https://crrev.com/ca9d8ac0a8735dacad863962c28a960c60747042
Cr-Commit-Position: refs/heads/master@{#406785}
==========

[commit-bot: I haz the power, 2016-07-21 06:27:56]

Patchset 1 (id:??) landed as
https://crrev.com/ca9d8ac0a8735dacad863962c28a960c60747042
Cr-Commit-Position: refs/heads/master@{#406785}