Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4184)

Unified Diff: chrome/browser/engagement/site_engagement_score_unittest.cc

Issue 2163233002: Allow rounding errors in Site Engagement tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/engagement/site_engagement_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/engagement/site_engagement_score_unittest.cc
diff --git a/chrome/browser/engagement/site_engagement_score_unittest.cc b/chrome/browser/engagement/site_engagement_score_unittest.cc
index 108185142b1a7f8aca374a3330a80fba0c1873be..625b75c34ce69725e68ec84d64d0fb482cd259f7 100644
--- a/chrome/browser/engagement/site_engagement_score_unittest.cc
+++ b/chrome/browser/engagement/site_engagement_score_unittest.cc
@@ -21,6 +21,7 @@ const int kLessDaysThanNeededToMaxTotalEngagement = 4;
const int kMoreDaysThanNeededToMaxTotalEngagement = 40;
const int kLessPeriodsThanNeededToDecayMaxScore = 2;
const int kMorePeriodsThanNeededToDecayMaxScore = 40;
+const double kMaxRoundingDeviation = 0.0001;
base::Time GetReferenceTime() {
base::Time::Exploded exploded_reference_time;
@@ -443,5 +444,5 @@ TEST_F(SiteEngagementScoreTest, ProportionalDecay) {
SetParamValue(SiteEngagementScore::DECAY_POINTS, 2.0);
current_day += base::TimeDelta::FromDays(7);
test_clock_.SetNow(current_day);
- EXPECT_DOUBLE_EQ(1.0, score_.GetScore());
+ EXPECT_NEAR(1.0, score_.GetScore(), kMaxRoundingDeviation);
}
« no previous file with comments | « no previous file | chrome/browser/engagement/site_engagement_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698