Allow rounding errors in Site Engagement tests

chrome/browser/engagement/site_engagement_service_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/engagement/site_engagement_service.h"
 
 #include <utility>
 
 #include "base/files/scoped_temp_dir.h"
 #include "base/macros.h"
@@ skipping 24 matching lines @@
 #include "content/public/test/web_contents_tester.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 base::FilePath g_temp_history_dir;
 
 const int kMoreAccumulationsThanNeededToMaxDailyEngagement = 40;
 const int kMoreDaysThanNeededToMaxTotalEngagement = 40;
 const int kMorePeriodsThanNeededToDecayMaxScore = 40;
+const double kMaxRoundingDeviation = 0.0001;
 
 // Waits until a change is observed in site engagement content settings.
 class SiteEngagementChangeWaiter : public content_settings::Observer {
  public:
   explicit SiteEngagementChangeWaiter(Profile* profile) : profile_(profile) {
     HostContentSettingsMapFactory::GetForProfile(profile)->AddObserver(this);
   }
   ~SiteEngagementChangeWaiter() override {
     HostContentSettingsMapFactory::GetForProfile(profile_)->RemoveObserver(
         this);
@@ skipping 120 matching lines @@
     content::WebContentsTester::For(web_contents())
         ->TestDidNavigate(web_contents()->GetMainFrame(), 1, pending_id, true,
                           url, transition);
     EXPECT_EQ(prev_score, service->GetScore(url));
   }
 
   void SetParamValue(SiteEngagementScore::Variation variation, double value) {
     SiteEngagementScore::GetParamValues()[variation].second = value;
   }
 
+  void AssertInRange(double expected, double actual) {
+    EXPECT_NEAR(expected, actual, kMaxRoundingDeviation);
+  }
+
  private:
   base::ScopedTempDir temp_dir_;
 };
 
 TEST_F(SiteEngagementServiceTest, GetMedianEngagement) {
   SiteEngagementService* service = SiteEngagementService::Get(profile());
   ASSERT_TRUE(service);
 
   GURL url1("http://www.google.com/");
   GURL url2("https://www.google.com/");
@@ skipping 754 matching lines @@
   GURL url1("https://www.google.com/");
   GURL url2("https://www.somewhereelse.com/");
 
   service->AddPoints(url1, 1.0);
   service->AddPoints(url2, 1.2);
 
   current_day += base::TimeDelta::FromDays(7);
   clock->SetNow(current_day);
   std::map<GURL, double> score_map = service->GetScoreMap();
   EXPECT_EQ(2u, score_map.size());
-  EXPECT_EQ(0.5, service->GetScore(url1));
-  EXPECT_EQ(0.6, service->GetScore(url2));
+  AssertInRange(0.5, service->GetScore(url1));
+  AssertInRange(0.6, service->GetScore(url2));
 
   service->CleanupEngagementScores(false);
   score_map = service->GetScoreMap();
   EXPECT_EQ(1u, score_map.size());
   EXPECT_EQ(0, service->GetScore(url1));
-  EXPECT_EQ(0.6, service->GetScore(url2));
+  AssertInRange(0.6, service->GetScore(url2));
 }
 
 TEST_F(SiteEngagementServiceTest, NavigationAccumulation) {
   GURL url("https://www.google.com/");
 
   SiteEngagementService* service = SiteEngagementService::Get(profile());
   ASSERT_TRUE(service);
 
   // Create the helper manually since it isn't present when a tab isn't created.
   SiteEngagementService::Helper::CreateForWebContents(web_contents());
@@ skipping 81 matching lines @@
   history->AddPage(origin2a, yesterday_afternoon, history::SOURCE_BROWSED);
   engagement->AddPoints(origin2, 5.0);
 
   history->AddPage(origin3, today, history::SOURCE_BROWSED);
   engagement->AddPoints(origin3, 5.0);
 
   history->AddPage(origin4, yesterday_week, history::SOURCE_BROWSED);
   history->AddPage(origin4a, yesterday_afternoon, history::SOURCE_BROWSED);
   engagement->AddPoints(origin4, 5.0);
 
-  EXPECT_EQ(3.0, engagement->GetScore(origin1));
-  EXPECT_EQ(5.0, engagement->GetScore(origin2));
-  EXPECT_EQ(5.0, engagement->GetScore(origin3));
-  EXPECT_EQ(5.0, engagement->GetScore(origin4));
+  AssertInRange(3.0, engagement->GetScore(origin1));
+  AssertInRange(5.0, engagement->GetScore(origin2));
+  AssertInRange(5.0, engagement->GetScore(origin3));
+  AssertInRange(5.0, engagement->GetScore(origin4));
 
   {
     SiteEngagementChangeWaiter waiter(profile());
 
     base::CancelableTaskTracker task_tracker;
     // Expire origin1, origin2, origin2a, and origin4's most recent visit.
     history->ExpireHistoryBetween(std::set<GURL>(), yesterday, today,
                                   base::Bind(&base::DoNothing), &task_tracker);
     waiter.Wait();
 
     // origin2 is cleaned up because all its urls are deleted. origin1a and
     // origin1b are still in history, but 33% of urls have been deleted, thus
     // cutting origin1's score by 1/3. origin3 is untouched. origin4 has 1 URL
     // deleted and 1 remaining, but its most recent visit is more than 1 week in
     // the past. Ensure that its scored is halved, and not decayed further.
-    EXPECT_EQ(2, engagement->GetScore(origin1));
+    AssertInRange(2, engagement->GetScore(origin1));
     EXPECT_EQ(0, engagement->GetScore(origin2));
-    EXPECT_EQ(5.0, engagement->GetScore(origin3));
-    EXPECT_EQ(2.5, engagement->GetScore(origin4));
-    EXPECT_EQ(9.5, engagement->GetTotalEngagementPoints());
+    AssertInRange(5.0, engagement->GetScore(origin3));
+    AssertInRange(2.5, engagement->GetScore(origin4));
+    AssertInRange(9.5, engagement->GetTotalEngagementPoints());
   }
 
   {
     SiteEngagementChangeWaiter waiter(profile());
 
     // Expire origin1a.
     std::vector<history::ExpireHistoryArgs> expire_list;
     history::ExpireHistoryArgs args;
     args.urls.insert(origin1a);
     args.SetTimeRangeForOneDay(yesterday_week);
     expire_list.push_back(args);
 
     base::CancelableTaskTracker task_tracker;
     history->ExpireHistory(expire_list, base::Bind(&base::DoNothing),
                            &task_tracker);
     waiter.Wait();
 
     // origin1's score should be halved again. origin3 and origin4 remain
     // untouched.
-    EXPECT_EQ(1, engagement->GetScore(origin1));
+    AssertInRange(1, engagement->GetScore(origin1));
     EXPECT_EQ(0, engagement->GetScore(origin2));
-    EXPECT_EQ(5.0, engagement->GetScore(origin3));
-    EXPECT_EQ(2.5, engagement->GetScore(origin4));
-    EXPECT_EQ(8.5, engagement->GetTotalEngagementPoints());
+    AssertInRange(5.0, engagement->GetScore(origin3));
+    AssertInRange(2.5, engagement->GetScore(origin4));
+    AssertInRange(8.5, engagement->GetTotalEngagementPoints());
   }
 
   {
     SiteEngagementChangeWaiter waiter(profile());
 
     // Expire origin1b.
     std::vector<history::ExpireHistoryArgs> expire_list;
     history::ExpireHistoryArgs args;
     args.urls.insert(origin1b);
     args.SetTimeRangeForOneDay(today);
     expire_list.push_back(args);
 
     base::CancelableTaskTracker task_tracker;
     history->ExpireHistory(expire_list, base::Bind(&base::DoNothing),
                            &task_tracker);
     waiter.Wait();
 
     // origin1 should be removed. origin3 and origin4 remain untouched.
     EXPECT_EQ(0, engagement->GetScore(origin1));
     EXPECT_EQ(0, engagement->GetScore(origin2));
-    EXPECT_EQ(5.0, engagement->GetScore(origin3));
-    EXPECT_EQ(2.5, engagement->GetScore(origin4));
-    EXPECT_EQ(7.5, engagement->GetTotalEngagementPoints());
+    AssertInRange(5.0, engagement->GetScore(origin3));
+    AssertInRange(2.5, engagement->GetScore(origin4));
+    AssertInRange(7.5, engagement->GetTotalEngagementPoints());
   }
 }
 
 TEST_F(SiteEngagementServiceTest, EngagementLevel) {
   static_assert(SiteEngagementService::ENGAGEMENT_LEVEL_NONE !=
                     SiteEngagementService::ENGAGEMENT_LEVEL_LOW,
                 "enum values should not be equal");
   static_assert(SiteEngagementService::ENGAGEMENT_LEVEL_LOW !=
                     SiteEngagementService::ENGAGEMENT_LEVEL_MEDIUM,
                 "enum values should not be equal");
@@ skipping 309 matching lines @@
   base::Time later_in_day = current_day + base::TimeDelta::FromSeconds(30);
   clock->SetNow(later_in_day);
   service->AddPoints(origin, 3);
 
   last_engagement_time = base::Time::FromInternalValue(
       profile()->GetPrefs()->GetInt64(prefs::kSiteEngagementLastUpdateTime));
 
   EXPECT_EQ(later_in_day, last_engagement_time);
   EXPECT_EQ(later_in_day, service->GetLastEngagementTime());
 }