Rename xfa_doclayout and xfa_document_layout_imp files.

Rename xfa_doclayout and xfa_document_layout_imp files.

This Cl moves the xfa_doclayout and xfa_document_layout_imp files to have
names based off of their classes.

Committed: https://pdfium.googlesource.com/pdfium/+/0b851fffe118d8be26e776256144a6b85495ce74

[dsinclair, 2016-07-20 15:34:01]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, weili@chromium.org

[dsinclair, 2016-07-20 15:34:01]

PTAL.

[Lei Zhang, 2016-07-20 22:51:23]

lgtm

https://codereview.chromium.org/2170473002/diff/60001/xfa/fxfa/parser/cxfa_co...
File xfa/fxfa/parser/cxfa_containerlayoutitem.cpp (right):

https://codereview.chromium.org/2170473002/diff/60001/xfa/fxfa/parser/cxfa_co...
xfa/fxfa/parser/cxfa_containerlayoutitem.cpp:27: void
CXFA_ContainerLayoutItem::GetPageSize(CFX_SizeF& size) const {
Not sure how many callers we have, but can we convert this to return a
CFX_SizeF?

https://codereview.chromium.org/2170473002/diff/60001/xfa/fxfa/parser/cxfa_la...
File xfa/fxfa/parser/cxfa_layoutitem.h (right):

https://codereview.chromium.org/2170473002/diff/60001/xfa/fxfa/parser/cxfa_la...
xfa/fxfa/parser/cxfa_layoutitem.h:35: CXFA_LayoutItem* GetPrev() const;
Should these also have the const/non-const overload?

https://codereview.chromium.org/2170473002/diff/60001/xfa/fxfa/parser/cxfa_tr...
File xfa/fxfa/parser/cxfa_traversestrategy_layoutitem.h (right):

https://codereview.chromium.org/2170473002/diff/60001/xfa/fxfa/parser/cxfa_tr...
xfa/fxfa/parser/cxfa_traversestrategy_layoutitem.h:14: static CXFA_LayoutItem*
GetFirstChild(CXFA_LayoutItem* pLayoutItem) {
Why aren't these CXFA_LayoutItem methods?

[dsinclair, 2016-07-21 13:12:47]

https://codereview.chromium.org/2170473002/diff/60001/xfa/fxfa/parser/cxfa_co...
File xfa/fxfa/parser/cxfa_containerlayoutitem.cpp (right):

https://codereview.chromium.org/2170473002/diff/60001/xfa/fxfa/parser/cxfa_co...
xfa/fxfa/parser/cxfa_containerlayoutitem.cpp:27: void
CXFA_ContainerLayoutItem::GetPageSize(CFX_SizeF& size) const {
On 2016/07/20 22:51:22, Lei Zhang wrote:
> Not sure how many callers we have, but can we convert this to return a
> CFX_SizeF?

Done.

https://codereview.chromium.org/2170473002/diff/60001/xfa/fxfa/parser/cxfa_la...
File xfa/fxfa/parser/cxfa_layoutitem.h (right):

https://codereview.chromium.org/2170473002/diff/60001/xfa/fxfa/parser/cxfa_la...
xfa/fxfa/parser/cxfa_layoutitem.h:35: CXFA_LayoutItem* GetPrev() const;
On 2016/07/20 22:51:22, Lei Zhang wrote:
> Should these also have the const/non-const overload?

I'd prefer to leave it as they aren't needed. If we need them we can add them.

https://codereview.chromium.org/2170473002/diff/60001/xfa/fxfa/parser/cxfa_tr...
File xfa/fxfa/parser/cxfa_traversestrategy_layoutitem.h (right):

https://codereview.chromium.org/2170473002/diff/60001/xfa/fxfa/parser/cxfa_tr...
xfa/fxfa/parser/cxfa_traversestrategy_layoutitem.h:14: static CXFA_LayoutItem*
GetFirstChild(CXFA_LayoutItem* pLayoutItem) {
On 2016/07/20 22:51:22, Lei Zhang wrote:
> Why aren't these CXFA_LayoutItem methods?

Because we have a bunch of TraverseStrategy classes that get passed into another
thing as an adapter.

[dsinclair, 2016-07-21 19:02:36]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-07-21 19:02:37]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2170473002/#ps100001
(title: "Review fixes")

[commit-bot: I haz the power, 2016-07-21 19:02:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 19:03:04]

Description was changed from

==========
Rename xfa_doclayout and xfa_document_layout_imp files.

This Cl moves the xfa_doclayout and xfa_document_layout_imp files to have
names based off of their classes.
==========

to

==========
Rename xfa_doclayout and xfa_document_layout_imp files.

This Cl moves the xfa_doclayout and xfa_document_layout_imp files to have
names based off of their classes.

Committed:
https://pdfium.googlesource.com/pdfium/+/0b851fffe118d8be26e776256144a6b85495...
==========

[commit-bot: I haz the power, 2016-07-21 19:03:05]

Committed patchset #6 (id:100001) as
https://pdfium.googlesource.com/pdfium/+/0b851fffe118d8be26e776256144a6b85495...