Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 216313006: Change if/else to if in two GrGLInterface factories (Closed)

Created:
6 years, 8 months ago by bsalomon
Modified:
6 years, 8 months ago
Reviewers:
rmistry, robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Change if/else to if in two GrGLInterface factories. TBR=robertphillips@google.com Committed: http://code.google.com/p/skia/source/detail?r=13996

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+440 lines, -442 lines) Patch
M src/gpu/gl/mesa/GrGLCreateMesaInterface.cpp View 1 chunk +195 lines, -196 lines 1 comment Download
M src/gpu/gl/unix/GrGLCreateNativeInterface_unix.cpp View 1 chunk +245 lines, -246 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bsalomon
https://codereview.chromium.org/216313006/diff/1/src/gpu/gl/mesa/GrGLCreateMesaInterface.cpp File src/gpu/gl/mesa/GrGLCreateMesaInterface.cpp (right): https://codereview.chromium.org/216313006/diff/1/src/gpu/gl/mesa/GrGLCreateMesaInterface.cpp#newcode25 src/gpu/gl/mesa/GrGLCreateMesaInterface.cpp:25: if (NULL == OSMesaGetCurrentContext()) { Rietveld is making the ...
6 years, 8 months ago (2014-03-28 21:32:54 UTC) #1
robertphillips
lgtm
6 years, 8 months ago (2014-03-30 17:22:02 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 8 months ago (2014-03-31 13:23:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/216313006/1
6 years, 8 months ago (2014-03-31 13:23:43 UTC) #4
rmistry
The CQ bit was unchecked by rmistry@google.com
6 years, 8 months ago (2014-03-31 18:32:31 UTC) #5
rmistry
The CQ bit was checked by rmistry@google.com
6 years, 8 months ago (2014-03-31 18:33:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/216313006/1
6 years, 8 months ago (2014-03-31 18:33:42 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 18:34:18 UTC) #8
Message was sent while issue was closed.
Change committed as 13996

Powered by Google App Engine
This is Rietveld 408576698