Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2163123002: MD Settings: Remove remnants of obsolete Full Screen top-level category. (Closed)

Created:
4 years, 5 months ago by dpapad
Modified:
4 years, 5 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Remove remnants of obsolete Full Screen top-level category. Those bits should have been removed by https://codereview.chromium.org/1895113002. An assertion error was thrown by either of the following 1) Navigating to chrome://md-settings/siteSettings/fullscreen, or 2) Triggering a force-rendering of the subpage in question (via search). BUG=629665 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/474d850f3c46faa21c3de38fb068734dc52247b2 Cr-Commit-Position: refs/heads/master@{#406640}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -33 lines) Patch
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/resources/settings/route.js View 1 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/search_settings.js View 1 2 chunks +2 lines, -18 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
dpapad
4 years, 5 months ago (2016-07-20 17:05:35 UTC) #9
Dan Beam
https://codereview.chromium.org/2163123002/diff/1/chrome/browser/resources/settings/privacy_page/privacy_page.html File chrome/browser/resources/settings/privacy_page/privacy_page.html (left): https://codereview.chromium.org/2163123002/diff/1/chrome/browser/resources/settings/privacy_page/privacy_page.html#oldcode180 chrome/browser/resources/settings/privacy_page/privacy_page.html:180: page-title="$i18n{siteSettingsCategoryFullscreen}"> please remove this string from the data source ...
4 years, 5 months ago (2016-07-20 18:03:37 UTC) #12
dpapad
https://codereview.chromium.org/2163123002/diff/1/chrome/browser/resources/settings/privacy_page/privacy_page.html File chrome/browser/resources/settings/privacy_page/privacy_page.html (left): https://codereview.chromium.org/2163123002/diff/1/chrome/browser/resources/settings/privacy_page/privacy_page.html#oldcode180 chrome/browser/resources/settings/privacy_page/privacy_page.html:180: page-title="$i18n{siteSettingsCategoryFullscreen}"> On 2016/07/20 at 18:03:37, Dan Beam wrote: > ...
4 years, 5 months ago (2016-07-20 18:22:05 UTC) #13
Dan Beam
lgtm
4 years, 5 months ago (2016-07-20 18:28:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163123002/20001
4 years, 5 months ago (2016-07-20 18:30:15 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-20 19:40:38 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 19:40:40 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 19:42:37 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/474d850f3c46faa21c3de38fb068734dc52247b2
Cr-Commit-Position: refs/heads/master@{#406640}

Powered by Google App Engine
This is Rietveld 408576698