MD Settings: Remove remnants of obsolete Full Screen top-level category.

MD Settings: Remove remnants of obsolete Full Screen top-level category.

Those bits should have been removed by https://codereview.chromium.org/1895113002.

An assertion error was thrown by either of the following
1) Navigating to chrome://md-settings/siteSettings/fullscreen, or
2) Triggering a force-rendering of the subpage in question (via search).

BUG=629665
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/474d850f3c46faa21c3de38fb068734dc52247b2
Cr-Commit-Position: refs/heads/master@{#406640}

[dpapad, 2016-07-20 01:12:51]

Description was changed from

==========
MD Settings: Remove remnants of obsolete FULLSCREEN top-level category.

BUG=629665
==========

to

==========
MD Settings: Remove remnants of obsolete FULLSCREEN top-level category.

BUG=629665
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-07-20 01:14:29]

Description was changed from

==========
MD Settings: Remove remnants of obsolete FULLSCREEN top-level category.

BUG=629665
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Remove remnants of obsolete FULLSCREEN top-level category.

An assertion error was thrown by either of the following
1) Navigating to chrome://md-settings/siteSettings/fullscreen, or
2) Triggering search a force-rendering of the subpage in question.

BUG=629665
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-07-20 01:14:53]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 01:15:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-07-20 01:16:09]

Description was changed from

==========
MD Settings: Remove remnants of obsolete FULLSCREEN top-level category.

An assertion error was thrown by either of the following
1) Navigating to chrome://md-settings/siteSettings/fullscreen, or
2) Triggering search a force-rendering of the subpage in question.

BUG=629665
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Remove remnants of obsolete FULLSCREEN top-level category.

Those bits should have been removed by
https://codereview.chromium.org/1895113002.

An assertion error was thrown by either of the following
1) Navigating to chrome://md-settings/siteSettings/fullscreen, or
2) Triggering search a force-rendering of the subpage in question.

BUG=629665
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-07-20 02:35:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 02:35:30]

Dry run: This issue passed the CQ dry run.

[dpapad, 2016-07-20 17:05:35]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2016-07-20 17:05:57]

Description was changed from

==========
MD Settings: Remove remnants of obsolete FULLSCREEN top-level category.

Those bits should have been removed by
https://codereview.chromium.org/1895113002.

An assertion error was thrown by either of the following
1) Navigating to chrome://md-settings/siteSettings/fullscreen, or
2) Triggering search a force-rendering of the subpage in question.

BUG=629665
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Remove remnants of obsolete Full Screen top-level category.

Those bits should have been removed by
https://codereview.chromium.org/1895113002.

An assertion error was thrown by either of the following
1) Navigating to chrome://md-settings/siteSettings/fullscreen, or
2) Triggering search a force-rendering of the subpage in question.

BUG=629665
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-07-20 17:06:24]

Description was changed from

==========
MD Settings: Remove remnants of obsolete Full Screen top-level category.

Those bits should have been removed by
https://codereview.chromium.org/1895113002.

An assertion error was thrown by either of the following
1) Navigating to chrome://md-settings/siteSettings/fullscreen, or
2) Triggering search a force-rendering of the subpage in question.

BUG=629665
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Remove remnants of obsolete Full Screen top-level category.

Those bits should have been removed by
https://codereview.chromium.org/1895113002.

An assertion error was thrown by either of the following
1) Navigating to chrome://md-settings/siteSettings/fullscreen, or
2) Triggering a force-rendering of the subpage in question (via search).

BUG=629665
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-07-20 18:03:37]

https://codereview.chromium.org/2163123002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (left):

https://codereview.chromium.org/2163123002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/privacy_page/privacy_page.html:180:
page-title="$i18n{siteSettingsCategoryFullscreen}">
please remove this string from the data source in C++
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:1087

https://codereview.chromium.org/2163123002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/search_settings.js (right):

https://codereview.chromium.org/2163123002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_settings.js:107: function
forceRenderNeeded_(node) {
i don't think this function is required, I think you'd inflate this file less by
doing something like

var needsRender =
    node.nodeName == 'TEMPLATE' && node.hasAttribute('name') && !node.if;
if (needsRender) {

or just

if (node.nodeName == 'TEMPLATE' && node.hasAttribute('name') && !node.if) {

[dpapad, 2016-07-20 18:22:05]

https://codereview.chromium.org/2163123002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/privacy_page/privacy_page.html (left):

https://codereview.chromium.org/2163123002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/privacy_page/privacy_page.html:180:
page-title="$i18n{siteSettingsCategoryFullscreen}">
On 2016/07/20 at 18:03:37, Dan Beam wrote:
> please remove this string from the data source in C++
>
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:1087

Done.

https://codereview.chromium.org/2163123002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/search_settings.js (right):

https://codereview.chromium.org/2163123002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/search_settings.js:107: function
forceRenderNeeded_(node) {
On 2016/07/20 at 18:03:37, Dan Beam wrote:
> i don't think this function is required, I think you'd inflate this file less
by doing something like
> 
> var needsRender =
>     node.nodeName == 'TEMPLATE' && node.hasAttribute('name') && !node.if;
> if (needsRender) {
> 
> or just
> 
> if (node.nodeName == 'TEMPLATE' && node.hasAttribute('name') && !node.if) {

Done.

[Dan Beam, 2016-07-20 18:28:53]

lgtm

[dpapad, 2016-07-20 18:29:42]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-07-20 18:30:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 19:40:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-20 19:40:40]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 19:42:36]

Description was changed from

==========
MD Settings: Remove remnants of obsolete Full Screen top-level category.

Those bits should have been removed by
https://codereview.chromium.org/1895113002.

An assertion error was thrown by either of the following
1) Navigating to chrome://md-settings/siteSettings/fullscreen, or
2) Triggering a force-rendering of the subpage in question (via search).

BUG=629665
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Remove remnants of obsolete Full Screen top-level category.

Those bits should have been removed by
https://codereview.chromium.org/1895113002.

An assertion error was thrown by either of the following
1) Navigating to chrome://md-settings/siteSettings/fullscreen, or
2) Triggering a force-rendering of the subpage in question (via search).

BUG=629665
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/474d850f3c46faa21c3de38fb068734dc52247b2
Cr-Commit-Position: refs/heads/master@{#406640}
==========

[commit-bot: I haz the power, 2016-07-20 19:42:37]

Patchset 2 (id:??) landed as
https://crrev.com/474d850f3c46faa21c3de38fb068734dc52247b2
Cr-Commit-Position: refs/heads/master@{#406640}