Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: chrome/browser/resources/settings/search_settings.js

Issue 2163123002: MD Settings: Remove remnants of obsolete Full Screen top-level category. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/search_settings.js
diff --git a/chrome/browser/resources/settings/search_settings.js b/chrome/browser/resources/settings/search_settings.js
index c328fe89c081a90e986389b256e2bc03e3260196..03f1062dc6533fc2e08f783b7cf298e153b8b760 100644
--- a/chrome/browser/resources/settings/search_settings.js
+++ b/chrome/browser/resources/settings/search_settings.js
@@ -98,23 +98,6 @@ cr.define('settings', function() {
}
/**
- * Checks whether the given |node| requires force rendering.
- *
- * @param {!SearchContext} context
- * @param {!Node} node
- * @return {boolean} Whether a forced rendering task was scheduled.
- * @private
- */
- function forceRenderNeeded_(context, node) {
- if (node.nodeName != 'TEMPLATE' || !node.hasAttribute('name') || node.if)
- return false;
-
- // TODO(dpapad): Temporarily ignore site-settings because it throws an
- // assertion error during force-rendering.
- return node.getAttribute('name').indexOf('site-') != 0;
- }
-
- /**
* Traverses the entire DOM (including Shadow DOM), finds text nodes that
* match the given regular expression and applies the highlight UI. It also
* ensures that <settings-section> instances become visible if any matches
@@ -126,7 +109,8 @@ cr.define('settings', function() {
*/
function findAndHighlightMatches_(context, root) {
function doSearch(node) {
- if (forceRenderNeeded_(context, node)) {
+ if (node.nodeName == 'TEMPLATE' && node.hasAttribute('name') &&
+ !node.if) {
getSearchManager().queue_.addRenderTask(
new RenderTask(context, node));
return;
« no previous file with comments | « chrome/browser/resources/settings/route.js ('k') | chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698