Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 1895113002: Site Settings: Remove FullScreen as top-level category. (Closed)

Created:
4 years, 8 months ago by Finnur
Modified:
4 years, 8 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Site Settings: Remove FullScreen as top-level category. Note: It is still accessible through the Site Details, if you look it up per site, but it doesn't need to be a top-level category. This CL also cleans up a few obsolete prefs-specific functions in the Behavior. BUG=543635 Committed: https://crrev.com/f3e513453ca688808092ce04405e6ef92f510b71 Cr-Commit-Position: refs/heads/master@{#388179}

Patch Set 1 #

Messages

Total messages: 11 (5 generated)
Finnur
4 years, 8 months ago (2016-04-18 15:24:38 UTC) #3
tommycli
lgtm assuming these changes are driven by modifications to the mocks? / with discussion with ...
4 years, 8 months ago (2016-04-18 16:14:12 UTC) #4
Finnur
FullScreen is going away as a specific permission, which is an effort driven by mgiuca@ ...
4 years, 8 months ago (2016-04-19 10:41:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895113002/1
4 years, 8 months ago (2016-04-19 10:41:44 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 10:44:54 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 10:46:35 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3e513453ca688808092ce04405e6ef92f510b71
Cr-Commit-Position: refs/heads/master@{#388179}

Powered by Google App Engine
This is Rietveld 408576698