[DevTools] Remove Object.values and Object.isEmpty from utilities.js

[DevTools] Remove Object.values and Object.isEmpty from utilities.js

- replaced some object-based maps with real Map;
- remove Object.values and Object.isEmpty from utilities.js;
- better typing;

Object.values method will be added in ES2017. Closure compiler already supports it via externs, to roll it we need to remove it. It was mostly used for Objects that were used for maps, it's better to have real maps instead.

R=dgozman@chromium.org,lushnikov@chromium.org

Committed: https://crrev.com/178c750299b0c864c76bbe64e6830144d02816ea
Cr-Commit-Position: refs/heads/master@{#406634}

[kozy, 2016-07-20 02:16:27]

Dmitry, please take a look!

[kozy, 2016-07-20 02:18:16]

Description was changed from

==========
[DevTools] Remove Object.values and Object.isEmpty from utilities.js

- replaced some object-based maps with real Map;
- remove Object.values and Object.isEmpty from utilities.js;
- better typing;

Object.values method will be added in ES2017. Closure compiler already supports
it via externs, to roll it we need to remove it. It was mostly used for Objects
that were used for maps, it's better to have real maps instead.

R=dgozman@chromium.org
==========

to

==========
[DevTools] Remove Object.values and Object.isEmpty from utilities.js

- replaced some object-based maps with real Map;
- remove Object.values and Object.isEmpty from utilities.js;
- better typing;

Object.values method will be added in ES2017. Closure compiler already supports
it via externs, to roll it we need to remove it. It was mostly used for Objects
that were used for maps, it's better to have real maps instead.

R=dgozman@chromium.org,lushnikov@chromium.org
==========

[kozy, 2016-07-20 02:18:16]

kozyatinskiy@chromium.org changed reviewers:
+ lushnikov@chromium.org

[kozy, 2016-07-20 02:18:29]

Andrey, please take a look!

[lushnikov, 2016-07-20 03:02:51]

lgtm, thanks!

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
(right):

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js:597:
var current = (this._numberOfDebuggerLocationForUILocation.get(uiLocation.id())
|| 0) - 1;
you can drop || 0

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
(right):

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js:500:
return Array.from(resources.values());
return resources.valuesArray();

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
(right):

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:92: result
= result.concat(Array.from(target.resourceTreeModel._frames.values()));
.valuesArray()

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:255: var
parentFrame = parentFrameId ? (this._frames.get(parentFrameId) || null) : null;
probably this could be written as

var parentFrame = this._frames.get(parentFrameId) || null;

though it's not identical to the previous code

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:394:
return Array.from(this._frames.values());
this._frames.valuesArray()

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js (right):

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js:69: return
Array.from(this._executionContextById.values()).sort(this.executionContextComparator());
valuesArray

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js (right):

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js:275: return
WebInspector.TracingModel.NamedObject._sort(Array.from(this._processById.values()));
valuesArray

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js:814: return
WebInspector.TracingModel.NamedObject._sort(Array.from(this._threads.values()));
valuesArray

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/snippets/SnippetStorage.js
(right):

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/snippets/SnippetStorage.js:66:
return Array.from(this._snippets.values());
valuesArray

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/snippets/SnippetStorage.js:84: for
(var snippet of this._snippets.values())
braces are missing

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
(right):

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js:1186:
return Array.from(causeToInvalidationMap.values());
valuesArray

[kozy, 2016-07-20 17:55:19]

all done, thanks!

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
(right):

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js:597:
var current = (this._numberOfDebuggerLocationForUILocation.get(uiLocation.id())
|| 0) - 1;
On 2016/07/20 03:02:50, lushnikov wrote:
> you can drop || 0

I can, but then I'll need to add type cast.

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
(right):

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js:500:
return Array.from(resources.values());
On 2016/07/20 03:02:50, lushnikov wrote:
> return resources.valuesArray();

Done.

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
(right):

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:92: result
= result.concat(Array.from(target.resourceTreeModel._frames.values()));
On 2016/07/20 03:02:50, lushnikov wrote:
> .valuesArray()

Done.

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:255: var
parentFrame = parentFrameId ? (this._frames.get(parentFrameId) || null) : null;
.get method for Map<string, *> can be called only with string, so I need this
logic to make compiler happy.

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js:394:
return Array.from(this._frames.values());
On 2016/07/20 03:02:50, lushnikov wrote:
> this._frames.valuesArray()

Done.

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js (right):

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js:69: return
Array.from(this._executionContextById.values()).sort(this.executionContextComparator());
On 2016/07/20 03:02:50, lushnikov wrote:
> valuesArray

Done.

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js (right):

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js:275: return
WebInspector.TracingModel.NamedObject._sort(Array.from(this._processById.values()));
On 2016/07/20 03:02:50, lushnikov wrote:
> valuesArray

Done.

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js:814: return
WebInspector.TracingModel.NamedObject._sort(Array.from(this._threads.values()));
On 2016/07/20 03:02:50, lushnikov wrote:
> valuesArray

Done.

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/snippets/SnippetStorage.js
(right):

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/snippets/SnippetStorage.js:66:
return Array.from(this._snippets.values());
On 2016/07/20 03:02:50, lushnikov wrote:
> valuesArray

Done.

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/snippets/SnippetStorage.js:84: for
(var snippet of this._snippets.values())
On 2016/07/20 03:02:50, lushnikov wrote:
> braces are missing

Done.

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
(right):

https://codereview.chromium.org/2163093003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js:1186:
return Array.from(causeToInvalidationMap.values());
On 2016/07/20 03:02:50, lushnikov wrote:
> valuesArray

Done.

[kozy, 2016-07-20 17:55:24]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-07-20 17:55:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2163093003/#ps20001
(title: "")

[commit-bot: I haz the power, 2016-07-20 17:55:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 19:12:38]

Description was changed from

==========
[DevTools] Remove Object.values and Object.isEmpty from utilities.js

- replaced some object-based maps with real Map;
- remove Object.values and Object.isEmpty from utilities.js;
- better typing;

Object.values method will be added in ES2017. Closure compiler already supports
it via externs, to roll it we need to remove it. It was mostly used for Objects
that were used for maps, it's better to have real maps instead.

R=dgozman@chromium.org,lushnikov@chromium.org
==========

to

==========
[DevTools] Remove Object.values and Object.isEmpty from utilities.js

- replaced some object-based maps with real Map;
- remove Object.values and Object.isEmpty from utilities.js;
- better typing;

Object.values method will be added in ES2017. Closure compiler already supports
it via externs, to roll it we need to remove it. It was mostly used for Objects
that were used for maps, it's better to have real maps instead.

R=dgozman@chromium.org,lushnikov@chromium.org
==========

[commit-bot: I haz the power, 2016-07-20 19:12:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-20 19:14:12]

Description was changed from

==========
[DevTools] Remove Object.values and Object.isEmpty from utilities.js

- replaced some object-based maps with real Map;
- remove Object.values and Object.isEmpty from utilities.js;
- better typing;

Object.values method will be added in ES2017. Closure compiler already supports
it via externs, to roll it we need to remove it. It was mostly used for Objects
that were used for maps, it's better to have real maps instead.

R=dgozman@chromium.org,lushnikov@chromium.org
==========

to

==========
[DevTools] Remove Object.values and Object.isEmpty from utilities.js

- replaced some object-based maps with real Map;
- remove Object.values and Object.isEmpty from utilities.js;
- better typing;

Object.values method will be added in ES2017. Closure compiler already supports
it via externs, to roll it we need to remove it. It was mostly used for Objects
that were used for maps, it's better to have real maps instead.

R=dgozman@chromium.org,lushnikov@chromium.org

Committed: https://crrev.com/178c750299b0c864c76bbe64e6830144d02816ea
Cr-Commit-Position: refs/heads/master@{#406634}
==========

[commit-bot: I haz the power, 2016-07-20 19:14:13]

Patchset 2 (id:??) landed as
https://crrev.com/178c750299b0c864c76bbe64e6830144d02816ea
Cr-Commit-Position: refs/heads/master@{#406634}