third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js - Issue 2163093003: [DevTools] Remove Object.values and Object.isEmpty from utilities.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js

Issue 2163093003: [DevTools] Remove Object.values and Object.isEmpty from utilities.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js ('k') | third_party/WebKit/Source/devtools/front_end/snippets/SnippetStorage.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js b/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js

index 15e04152973af2ea073e2834b5c1e3359bdbc924..b771ffd8ecd29ffe6ed3ba1f52adad1a427697f1 100644

--- a/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js

@@ -96,9 +96,8 @@ WebInspector.ScriptSnippetModel.prototype = {

_loadSnippets: function()

{

- var snippets = this._snippetStorage.snippets();

- for (var i = 0; i < snippets.length; ++i)

- this._addScriptSnippet(snippets[i]);

+ for (var snippet of this._snippetStorage.snippets())

+ this._addScriptSnippet(snippet);

/**

@@ -146,6 +145,8 @@ WebInspector.ScriptSnippetModel.prototype = {

return;

var snippetId = this._snippetIdForUISourceCode.get(uiSourceCode) || "";

var snippet = this._snippetStorage.snippetForId(snippetId);

+ if (!snippet)

+ return;

this._snippetStorage.deleteSnippet(snippet);

this._removeBreakpoints(uiSourceCode);

this._releaseSnippetScript(uiSourceCode);