Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

Issue 2163093003: [DevTools] Remove Object.values and Object.isEmpty from utilities.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
diff --git a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
index a56bdb62449785b25b1ea490b8b5386a717be7f6..4ac4041899686f5836cd0a046706b430c48e9e9e 100644
--- a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
+++ b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
@@ -477,26 +477,27 @@ WebInspector.ExtensionServer.prototype = {
},
/**
- * @return {!Array.<!WebInspector.ContentProvider>}
+ * @return {!Array<!WebInspector.ContentProvider>}
*/
_onGetPageResources: function()
{
- var resources = {};
+ /** @type {!Map<string, !WebInspector.ContentProvider>} */
+ var resources = new Map();
/**
* @this {WebInspector.ExtensionServer}
*/
function pushResourceData(contentProvider)
{
- if (!resources[contentProvider.contentURL()])
- resources[contentProvider.contentURL()] = this._makeResource(contentProvider);
+ if (!resources.has(contentProvider.contentURL()))
+ resources.set(contentProvider.contentURL(), this._makeResource(contentProvider));
}
var uiSourceCodes = WebInspector.workspace.uiSourceCodesForProjectType(WebInspector.projectTypes.Network);
uiSourceCodes = uiSourceCodes.concat(WebInspector.workspace.uiSourceCodesForProjectType(WebInspector.projectTypes.ContentScripts));
uiSourceCodes.forEach(pushResourceData.bind(this));
for (var target of WebInspector.targetManager.targets())
target.resourceTreeModel.forAllResources(pushResourceData.bind(this));
- return Object.values(resources);
+ return resources.valuesArray();
},
/**

Powered by Google App Engine
This is Rietveld 408576698