Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2162603002: Reland of New PaintController under-invalidation checking (Closed)

Created:
4 years, 5 months ago by Xianzhu
Modified:
4 years, 5 months ago
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@CommitOnTheWay
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of New PaintController under-invalidation checking (patchset #1 id:1 of https://codereview.chromium.org/2156053002/ ) Reason for revert: The original CL is to discover such bugs. Will mark the test failure in the reland. Original issue's description: > Revert of New PaintController under-invalidation checking (patchset #7 id:120001 of https://codereview.chromium.org/2114653003/ ) > > Reason for revert: > NOTREACHED being hit in checkUnderInvalidation on WebKit Win7 (dbg); see https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/6481. > > Original issue's description: > > New PaintController under-invalidation checking > > > > This is a follow-up of https://codereview.chromium.org/2107103002/ > > which broke the original under-invalidation checking in > > PaintController. > > > > BUG=596983, 510908 > > > > Committed: https://crrev.com/63b12484f2c59ba177a21aba09b8a4edd38e6ea1 > > Cr-Commit-Position: refs/heads/master@{#405805} > > TBR=chrishtr@chromium.org,pdr@chromium.org,wangxianzhu@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=596983, 510908 > > Committed: https://crrev.com/f2f05c78616f02157cd1414905a8692f227d9a64 > Cr-Commit-Position: refs/heads/master@{#405988} TBR=chrishtr@chromium.org,pdr@chromium.org,grt@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=596983, 510908 Committed: https://crrev.com/ecaad1e063c8e6c7033733a040250e38d1ddee28 Cr-Commit-Position: refs/heads/master@{#406016}

Patch Set 1 #

Patch Set 2 : TestExpectations #

Messages

Total messages: 10 (5 generated)
Xianzhu
Created Reland of New PaintController under-invalidation checking
4 years, 5 months ago (2016-07-18 16:50:25 UTC) #2
chrishtr
lgtm
4 years, 5 months ago (2016-07-18 16:52:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162603002/170001
4 years, 5 months ago (2016-07-18 16:54:31 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:170001)
4 years, 5 months ago (2016-07-18 16:55:15 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 16:56:45 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ecaad1e063c8e6c7033733a040250e38d1ddee28
Cr-Commit-Position: refs/heads/master@{#406016}

Powered by Google App Engine
This is Rietveld 408576698