New PaintController under-invalidation checking

New PaintController under-invalidation checking

This is a follow-up of https://codereview.chromium.org/2107103002/
which broke the original under-invalidation checking in
PaintController.

BUG=596983, 510908
Committed: https://crrev.com/63b12484f2c59ba177a21aba09b8a4edd38e6ea1
Cr-Commit-Position: refs/heads/master@{#405805}

[Xianzhu, 2016-07-13 20:55:26]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 20:56:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 22:01:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 22:01:10]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Xianzhu, 2016-07-14 21:45:15]

Description was changed from

==========
Implementation of new PaintController under-invalidation checking

BUG=596983,510908
==========

to

==========
New PaintController under-invalidation checking

BUG=596983,510908
==========

[Xianzhu, 2016-07-14 21:58:38]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 21:59:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-07-14 23:09:14]

Description was changed from

==========
New PaintController under-invalidation checking

BUG=596983,510908
==========

to

==========
New PaintController under-invalidation checking

This is a follow-up of https://codereview.chromium.org/2107103002/
which broke the original under-invalidation checking in
PaintController.

BUG=596983,510908
==========

[Xianzhu, 2016-07-14 23:09:26]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org, pdr@chromium.org

[commit-bot: I haz the power, 2016-07-14 23:30:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 23:30:38]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2016-07-15 00:57:44]

lgtm

https://codereview.chromium.org/2114653003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/graphics/paint/PaintController.h
(right):

https://codereview.chromium.org/2114653003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/graphics/paint/PaintController.h:267:
DisplayItemList::iterator m_underInvalidationCheckingBegin;
Please document these a little bit.

[Xianzhu, 2016-07-15 17:29:28]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-07-15 17:29:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2114653003/#ps120001
(title: "Doc m_underInvalidationCheckingBegin and End")

[commit-bot: I haz the power, 2016-07-15 17:30:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 18:52:25]

Description was changed from

==========
New PaintController under-invalidation checking

This is a follow-up of https://codereview.chromium.org/2107103002/
which broke the original under-invalidation checking in
PaintController.

BUG=596983,510908
==========

to

==========
New PaintController under-invalidation checking

This is a follow-up of https://codereview.chromium.org/2107103002/
which broke the original under-invalidation checking in
PaintController.

BUG=596983,510908
==========

[commit-bot: I haz the power, 2016-07-15 18:52:27]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-07-15 18:53:31]

Description was changed from

==========
New PaintController under-invalidation checking

This is a follow-up of https://codereview.chromium.org/2107103002/
which broke the original under-invalidation checking in
PaintController.

BUG=596983,510908
==========

to

==========
New PaintController under-invalidation checking

This is a follow-up of https://codereview.chromium.org/2107103002/
which broke the original under-invalidation checking in
PaintController.

BUG=596983,510908

Committed: https://crrev.com/63b12484f2c59ba177a21aba09b8a4edd38e6ea1
Cr-Commit-Position: refs/heads/master@{#405805}
==========

[commit-bot: I haz the power, 2016-07-15 18:53:32]

Patchset 7 (id:??) landed as
https://crrev.com/63b12484f2c59ba177a21aba09b8a4edd38e6ea1
Cr-Commit-Position: refs/heads/master@{#405805}

[grt (UTC plus 2), 2016-07-18 10:53:34]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2156053002/ by grt@chromium.org.

The reason for reverting is: NOTREACHED being hit in checkUnderInvalidation on
WebKit Win7 (dbg); see
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%....

[Xianzhu, 2016-07-18 16:26:36]

On 2016/07/18 10:53:34, grt (UTC plus 2) wrote:
> A revert of this CL (patchset #7 id:120001) has been created in
> https://codereview.chromium.org/2156053002/ by mailto:grt@chromium.org.
> 
> The reason for reverting is: NOTREACHED being hit in checkUnderInvalidation on
> WebKit Win7 (dbg); see
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%....

Next time encountering such problem, please just file a bug mark the test
failure and assign the bug to me.

This CL is to discover such bugs.