third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h - Issue 2162603002: Reland of New PaintController under-invalidation checking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h

Issue 2162603002: Reland of New PaintController under-invalidation checking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@CommitOnTheWay

Patch Set: TestExpectations Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/resources/run-after-layout-and-paint.js ('k') | third_party/WebKit/Source/platform/graphics/paint/PaintController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h

diff --git a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h

index 166619c669315b7145f05ad31766fa0f06f5f049..cf3293139db04a44b966a3907dfcb88fb0b1ed0f 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h

+++ b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h

@@ -45,9 +45,10 @@ public:

DisplayItem& appendByMoving(DisplayItem&);

+ bool hasVisualRect(unsigned index) const { return index < m_visualRects.size(); }

IntRect visualRect(unsigned index) const

{

- ASSERT(index < m_visualRects.size());

+ DCHECK(hasVisualRect(index));

return m_visualRects[index];

}