[telemetry] Trace config should be used to disable periodic dumps

[telemetry] Trace config should be used to disable periodic dumps

Telemetry previously used the "--enable-memory-benchmarking" flag to
tell memory dump manager to disable periodic dumps. That is cleaned up
in this CL and the trace config is used to achieve this behavior.

Note to perf sheriff: Memory benchmarks could regress if the config
did not propagate correctly.

BUG=513692
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq

Committed: https://crrev.com/578e8ff55813d82c373563039f8ab4db28264ed6
Cr-Commit-Position: refs/heads/master@{#406598}

[ssid, 2016-07-20 01:04:27]

Description was changed from

==========
[telemetry] Trace config should be used to disable periodic dumps

Telemetry previously used the "--enable-memory-benchmarking" flag to
tell memory dump manager to disable periodic dumps. That is cleaned up
in this CL and the trace config is used to achieve this behavior.

BUG=513692
==========

to

==========
[telemetry] Trace config should be used to disable periodic dumps

Telemetry previously used the "--enable-memory-benchmarking" flag to
tell memory dump manager to disable periodic dumps. That is cleaned up
in this CL and the trace config is used to achieve this behavior.

BUG=513692
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
==========

[ssid, 2016-07-20 01:11:14]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 01:12:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ssid, 2016-07-20 01:12:48]

Description was changed from

==========
[telemetry] Trace config should be used to disable periodic dumps

Telemetry previously used the "--enable-memory-benchmarking" flag to
tell memory dump manager to disable periodic dumps. That is cleaned up
in this CL and the trace config is used to achieve this behavior.

BUG=513692
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
[telemetry] Trace config should be used to disable periodic dumps

Telemetry previously used the "--enable-memory-benchmarking" flag to
tell memory dump manager to disable periodic dumps. That is cleaned up
in this CL and the trace config is used to achieve this behavior.

Note to perf sheriff: Memory benchmarks could regress if the config
did not propagate correctly.

BUG=513692
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
==========

[ssid, 2016-07-20 03:23:57]

ssid@chromium.org changed reviewers:
+ nednguyen@google.com

[commit-bot: I haz the power, 2016-07-20 04:12:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 04:12:43]

Dry run: This issue passed the CQ dry run.

[nednguyen, 2016-07-20 11:43:33]

lgtm

[ssid, 2016-07-20 17:19:21]

The CQ bit was checked by ssid@chromium.org

[commit-bot: I haz the power, 2016-07-20 17:20:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 17:26:40]

Description was changed from

==========
[telemetry] Trace config should be used to disable periodic dumps

Telemetry previously used the "--enable-memory-benchmarking" flag to
tell memory dump manager to disable periodic dumps. That is cleaned up
in this CL and the trace config is used to achieve this behavior.

Note to perf sheriff: Memory benchmarks could regress if the config
did not propagate correctly.

BUG=513692
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
[telemetry] Trace config should be used to disable periodic dumps

Telemetry previously used the "--enable-memory-benchmarking" flag to
tell memory dump manager to disable periodic dumps. That is cleaned up
in this CL and the trace config is used to achieve this behavior.

Note to perf sheriff: Memory benchmarks could regress if the config
did not propagate correctly.

BUG=513692
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
==========

[commit-bot: I haz the power, 2016-07-20 17:26:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-20 17:29:57]

Description was changed from

==========
[telemetry] Trace config should be used to disable periodic dumps

Telemetry previously used the "--enable-memory-benchmarking" flag to
tell memory dump manager to disable periodic dumps. That is cleaned up
in this CL and the trace config is used to achieve this behavior.

Note to perf sheriff: Memory benchmarks could regress if the config
did not propagate correctly.

BUG=513692
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
[telemetry] Trace config should be used to disable periodic dumps

Telemetry previously used the "--enable-memory-benchmarking" flag to
tell memory dump manager to disable periodic dumps. That is cleaned up
in this CL and the trace config is used to achieve this behavior.

Note to perf sheriff: Memory benchmarks could regress if the config
did not propagate correctly.

BUG=513692
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq

Committed: https://crrev.com/578e8ff55813d82c373563039f8ab4db28264ed6
Cr-Commit-Position: refs/heads/master@{#406598}
==========

[commit-bot: I haz the power, 2016-07-20 17:29:58]

Patchset 1 (id:??) landed as
https://crrev.com/578e8ff55813d82c373563039f8ab4db28264ed6
Cr-Commit-Position: refs/heads/master@{#406598}

[ssid, 2016-07-20 22:20:15]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2166833003/ by ssid@chromium.org.

The reason for reverting is: Looks like some reference builds still haven't got
the devtools api update..

[ssid, 2016-07-20 22:20:44]

On 2016/07/20 22:20:15, ssid wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2166833003/ by mailto:ssid@chromium.org.
> 
> The reason for reverting is: Looks like some reference builds still haven't
got
> the devtools api update..

https://bugs.chromium.org/p/chromium/issues/detail?id=629988