Index: tools/perf/benchmarks/v8.py |
diff --git a/tools/perf/benchmarks/v8.py b/tools/perf/benchmarks/v8.py |
index 6d7eb7acc5e02b8095d0ff3cb7a8746390fe3451..2cab3fd5911c2734d96b9af7c83ab569796a5c08 100644 |
--- a/tools/perf/benchmarks/v8.py |
+++ b/tools/perf/benchmarks/v8.py |
@@ -15,8 +15,8 @@ from measurements import v8_gc_times |
import page_sets |
from telemetry import benchmark |
from telemetry import story |
-from telemetry.timeline import chrome_trace_config |
from telemetry.timeline import chrome_trace_category_filter |
+from telemetry.timeline import chrome_trace_config |
from telemetry.web_perf import timeline_based_measurement |
@@ -84,9 +84,6 @@ class _InfiniteScrollBenchmark(perf_benchmark.PerfBenchmark): |
def SetExtraBrowserOptions(self, options): |
options.AppendExtraBrowserArgs([ |
- # TODO(perezju): Temporary workaround to disable periodic memory dumps. |
- # See: http://crbug.com/513692 |
- '--enable-memory-benchmarking', |
# Disable push notifications for Facebook. |
'--disable-notifications', |
]) |
@@ -106,6 +103,9 @@ class _InfiniteScrollBenchmark(perf_benchmark.PerfBenchmark): |
# TODO(ulan): Add frame time discrepancy once it is ported to TBMv2, |
# see crbug.com/606841. |
options.SetTimelineBasedMetrics(['v8AndMemoryMetrics']) |
+ # Setting an empty memory dump config disables periodic dumps. |
+ options.config.chrome_trace_config.SetMemoryDumpConfig( |
+ chrome_trace_config.MemoryDumpConfig()) |
return options |
@classmethod |