[telemetry] Trace config should be used to disable periodic dumps

tools/perf/benchmarks/v8.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import os
 import re
 
 from core import path_util
 from core import perf_benchmark
 from page_sets import google_pages
 
 from benchmarks import v8_helper
 
 from measurements import v8_detached_context_age_in_gc
 from measurements import v8_gc_times
 import page_sets
 from telemetry import benchmark
 from telemetry import story
+from telemetry.timeline import chrome_trace_category_filter
 from telemetry.timeline import chrome_trace_config
-from telemetry.timeline import chrome_trace_category_filter
 from telemetry.web_perf import timeline_based_measurement
 
 
 def CreateV8TimelineBasedMeasurementOptions():
   category_filter = chrome_trace_category_filter.ChromeTraceCategoryFilter()
   category_filter.AddIncludedCategory('v8')
   category_filter.AddIncludedCategory('blink.console')
   category_filter.AddDisabledByDefault('disabled-by-default-v8.compile')
   options = timeline_based_measurement.Options(category_filter)
   options.SetTimelineBasedMetrics(['executionMetric'])
@@ skipping 47 matching lines @@
   def Name(cls):
     return 'v8.detached_context_age_in_gc'
 
 
 class _InfiniteScrollBenchmark(perf_benchmark.PerfBenchmark):
   """ Base class for infinite scroll benchmarks.
   """
 
   def SetExtraBrowserOptions(self, options):
     options.AppendExtraBrowserArgs([
-        # TODO(perezju): Temporary workaround to disable periodic memory dumps.
-        # See: http://crbug.com/513692
-        '--enable-memory-benchmarking',
         # Disable push notifications for Facebook.
         '--disable-notifications',
     ])
     v8_helper.AppendJSFlags(options, '--heap-growing-percent=10')
 
   def CreateTimelineBasedMeasurementOptions(self):
     v8_categories = [
         'blink.console', 'disabled-by-default-v8.gc',
         'renderer.scheduler', 'v8', 'webkit.console']
     smoothness_categories = [
         'webkit.console', 'blink.console', 'benchmark', 'trace_event_overhead']
     memory_categories = ['blink.console', 'disabled-by-default-memory-infra']
     category_filter = chrome_trace_category_filter.ChromeTraceCategoryFilter(
         ','.join(['-*'] + v8_categories +
                  smoothness_categories + memory_categories))
     options = timeline_based_measurement.Options(category_filter)
     # TODO(ulan): Add frame time discrepancy once it is ported to TBMv2,
     # see crbug.com/606841.
     options.SetTimelineBasedMetrics(['v8AndMemoryMetrics'])
+    # Setting an empty memory dump config disables periodic dumps.
+    options.config.chrome_trace_config.SetMemoryDumpConfig(
+        chrome_trace_config.MemoryDumpConfig())
     return options
 
   @classmethod
   def ValueCanBeAddedPredicate(cls, value, _):
     return 'v8' in value.name
 
   @classmethod
   def ShouldTearDownStateAfterEachStoryRun(cls):
     return True
 
@@ skipping 184 matching lines @@
       return True
     # http://crbug.com/623576
     if (possible_browser.platform.GetDeviceTypeName() == 'Nexus 5' or
         possible_browser.platform.GetDeviceTypeName() == 'Nexus 7'):
       return True
     return False
 
   @classmethod
   def ShouldTearDownStateAfterEachStoryRun(cls):
     return True