Remove default parameters from CXFA_SimpleParser.

Remove default parameters from CXFA_SimpleParser.

This CL removes default params from CXFA_SimpleParser and updates the call sites
as necessary.

Committed: https://pdfium.googlesource.com/pdfium/+/a89f6be04bebbbf01686db167446df081a7042e0

[dsinclair, 2016-07-20 19:49:21]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, weili@chromium.org

[dsinclair, 2016-07-20 19:49:22]

PTAL.

[Wei Li, 2016-07-20 22:58:14]

https://codereview.chromium.org/2164963003/diff/1/xfa/fxfa/parser/cxfa_simple...
File xfa/fxfa/parser/cxfa_simple_parser.cpp (right):

https://codereview.chromium.org/2164963003/diff/1/xfa/fxfa/parser/cxfa_simple...
xfa/fxfa/parser/cxfa_simple_parser.cpp:390: m_pRootNode = NormalLoader(pXFANode,
pXMLNode, ePacketID, TRUE);
If they are all TRUE, do we still need this parameter?

[dsinclair, 2016-07-21 13:22:25]

https://codereview.chromium.org/2164963003/diff/1/xfa/fxfa/parser/cxfa_simple...
File xfa/fxfa/parser/cxfa_simple_parser.cpp (right):

https://codereview.chromium.org/2164963003/diff/1/xfa/fxfa/parser/cxfa_simple...
xfa/fxfa/parser/cxfa_simple_parser.cpp:390: m_pRootNode = NormalLoader(pXFANode,
pXMLNode, ePacketID, TRUE);
On 2016/07/20 22:58:14, Wei Li wrote:
> If they are all TRUE, do we still need this parameter?

There are 3 instances which use bUseAttribute which could be FALSE.

[Wei Li, 2016-07-21 17:07:30]

lgtm

[dsinclair, 2016-07-21 19:12:22]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-07-21 19:12:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 19:17:50]

Description was changed from

==========
Remove default parameters from CXFA_SimpleParser.

This CL removes default params from CXFA_SimpleParser and updates the call sites
as necessary.
==========

to

==========
Remove default parameters from CXFA_SimpleParser.

This CL removes default params from CXFA_SimpleParser and updates the call sites
as necessary.

Committed:
https://pdfium.googlesource.com/pdfium/+/a89f6be04bebbbf01686db167446df081a70...
==========

[commit-bot: I haz the power, 2016-07-21 19:17:52]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/a89f6be04bebbbf01686db167446df081a70...