Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2161563002: Revert of [interpeter] Move to table based peephole optimizer. (Closed)

Created:
4 years, 5 months ago by oth
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [interpeter] Move to table based peephole optimizer. (patchset #38 id:730001 of https://codereview.chromium.org/2118183002/ ) Reason for revert: Break MIPS port. Original issue's description: > [interpeter] Move to table based peephole optimizer. > > Introduces a lookup table for peephole optimizations. > > Fixes some tests using BytecodePeepholeOptimizer::Write() that should > have been update to use BytecodePeepholeOptimizer::WriteJump(). > > BUG=v8:4280 > LOG=N > > Committed: https://crrev.com/f4234422b93b21a286b0f31799009bcbe8b90b9e > Cr-Commit-Position: refs/heads/master@{#37819} TBR=rmcilroy@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280 Committed: https://crrev.com/eae40165e1c667d48369abb6f22ec1276db66473 Cr-Commit-Position: refs/heads/master@{#37821}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -839 lines) Patch
M BUILD.gn View 5 chunks +0 lines, -49 lines 0 comments Download
M src/interpreter/bytecode-peephole-optimizer.h View 3 chunks +16 lines, -13 lines 0 comments Download
M src/interpreter/bytecode-peephole-optimizer.cc View 7 chunks +245 lines, -236 lines 0 comments Download
D src/interpreter/bytecode-peephole-table.h View 1 chunk +0 lines, -73 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/interpreter/bytecodes.cc View 2 chunks +5 lines, -5 lines 0 comments Download
D src/interpreter/mkpeephole.cc View 1 chunk +0 lines, -387 lines 0 comments Download
M src/v8.gyp View 4 chunks +1 line, -42 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ConstVariable.golden View 2 chunks +2 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LetVariable.golden View 2 chunks +2 lines, -1 line 0 comments Download
M test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc View 6 chunks +38 lines, -29 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
oth
Created Revert of [interpeter] Move to table based peephole optimizer.
4 years, 5 months ago (2016-07-18 08:51:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161563002/1
4 years, 5 months ago (2016-07-18 08:51:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 08:51:51 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 08:51:52 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 08:55:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eae40165e1c667d48369abb6f22ec1276db66473
Cr-Commit-Position: refs/heads/master@{#37821}

Powered by Google App Engine
This is Rietveld 408576698