Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: src/interpreter/bytecode-peephole-optimizer.h

Issue 2161563002: Revert of [interpeter] Move to table based peephole optimizer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « BUILD.gn ('k') | src/interpreter/bytecode-peephole-optimizer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_INTERPRETER_BYTECODE_PEEPHOLE_OPTIMIZER_H_ 5 #ifndef V8_INTERPRETER_BYTECODE_PEEPHOLE_OPTIMIZER_H_
6 #define V8_INTERPRETER_BYTECODE_PEEPHOLE_OPTIMIZER_H_ 6 #define V8_INTERPRETER_BYTECODE_PEEPHOLE_OPTIMIZER_H_
7 7
8 #include "src/interpreter/bytecode-peephole-table.h"
9 #include "src/interpreter/bytecode-pipeline.h" 8 #include "src/interpreter/bytecode-pipeline.h"
10 9
11 namespace v8 { 10 namespace v8 {
12 namespace internal { 11 namespace internal {
13 namespace interpreter { 12 namespace interpreter {
14 13
15 class ConstantArrayBuilder; 14 class ConstantArrayBuilder;
16 class BytecodePeepholeActionAndData;
17 15
18 // An optimization stage for performing peephole optimizations on 16 // An optimization stage for performing peephole optimizations on
19 // generated bytecode. The optimizer may buffer one bytecode 17 // generated bytecode. The optimizer may buffer one bytecode
20 // internally. 18 // internally.
21 class BytecodePeepholeOptimizer final : public BytecodePipelineStage, 19 class BytecodePeepholeOptimizer final : public BytecodePipelineStage,
22 public ZoneObject { 20 public ZoneObject {
23 public: 21 public:
24 BytecodePeepholeOptimizer(ConstantArrayBuilder* constant_array_builder, 22 BytecodePeepholeOptimizer(ConstantArrayBuilder* constant_array_builder,
25 BytecodePipelineStage* next_stage); 23 BytecodePipelineStage* next_stage);
26 24
27 // BytecodePipelineStage interface. 25 // BytecodePipelineStage interface.
28 void Write(BytecodeNode* node) override; 26 void Write(BytecodeNode* node) override;
29 void WriteJump(BytecodeNode* node, BytecodeLabel* label) override; 27 void WriteJump(BytecodeNode* node, BytecodeLabel* label) override;
30 void BindLabel(BytecodeLabel* label) override; 28 void BindLabel(BytecodeLabel* label) override;
31 void BindLabel(const BytecodeLabel& target, BytecodeLabel* label) override; 29 void BindLabel(const BytecodeLabel& target, BytecodeLabel* label) override;
32 Handle<BytecodeArray> ToBytecodeArray( 30 Handle<BytecodeArray> ToBytecodeArray(
33 int fixed_register_count, int parameter_count, 31 int fixed_register_count, int parameter_count,
34 Handle<FixedArray> handler_table) override; 32 Handle<FixedArray> handler_table) override;
35 33
36 private: 34 private:
37 #define DECLARE_ACTION(Action) \ 35 BytecodeNode* OptimizeAndEmitLast(BytecodeNode* current);
38 void Action(BytecodeNode* const node, \ 36 BytecodeNode* Optimize(BytecodeNode* current);
39 const PeepholeActionAndData* const action_data = nullptr); 37 void Flush();
40 PEEPHOLE_ACTION_LIST(DECLARE_ACTION)
41 #undef DECLARE_ACTION
42 38
43 void ApplyPeepholeAction(BytecodeNode* const node); 39 void TryToRemoveLastExpressionPosition(const BytecodeNode* const current);
44 void Flush(); 40 bool TransformCurrentBytecode(BytecodeNode* const current);
41 bool TransformLastAndCurrentBytecodes(BytecodeNode* const current);
42 bool CanElideCurrent(const BytecodeNode* const current) const;
43 bool CanElideLast(const BytecodeNode* const current) const;
45 bool CanElideLastBasedOnSourcePosition( 44 bool CanElideLastBasedOnSourcePosition(
46 const BytecodeNode* const current) const; 45 const BytecodeNode* const current) const;
46
47 // Simple substitution methods.
48 bool RemoveToBooleanFromJump(BytecodeNode* const current);
49 bool RemoveToBooleanFromLogicalNot(BytecodeNode* const current);
50
47 void InvalidateLast(); 51 void InvalidateLast();
48 bool LastIsValid() const; 52 bool LastIsValid() const;
49 void SetLast(const BytecodeNode* const node); 53 void SetLast(const BytecodeNode* const node);
50 54
55 bool LastBytecodePutsNameInAccumulator() const;
56
51 Handle<Object> GetConstantForIndexOperand(const BytecodeNode* const node, 57 Handle<Object> GetConstantForIndexOperand(const BytecodeNode* const node,
52 int index) const; 58 int index) const;
53 59
54 BytecodePipelineStage* next_stage() const { return next_stage_; }
55 BytecodeNode* last() { return &last_; }
56
57 ConstantArrayBuilder* constant_array_builder_; 60 ConstantArrayBuilder* constant_array_builder_;
58 BytecodePipelineStage* next_stage_; 61 BytecodePipelineStage* next_stage_;
59 BytecodeNode last_; 62 BytecodeNode last_;
60 63
61 DISALLOW_COPY_AND_ASSIGN(BytecodePeepholeOptimizer); 64 DISALLOW_COPY_AND_ASSIGN(BytecodePeepholeOptimizer);
62 }; 65 };
63 66
64 } // namespace interpreter 67 } // namespace interpreter
65 } // namespace internal 68 } // namespace internal
66 } // namespace v8 69 } // namespace v8
67 70
68 #endif // V8_INTERPRETER_BYTECODE_PEEPHOLE_OPTIMIZER_H_ 71 #endif // V8_INTERPRETER_BYTECODE_PEEPHOLE_OPTIMIZER_H_
OLDNEW
« no previous file with comments | « BUILD.gn ('k') | src/interpreter/bytecode-peephole-optimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698