Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: BUILD.gn

Issue 2161563002: Revert of [interpeter] Move to table based peephole optimizer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/interpreter/bytecode-peephole-optimizer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 245c63a49dfb58779441c56284724beb8cc697e1..24f339044f155f7760e3482fa22cf13a4c889fbf 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -86,7 +86,6 @@
}
}
-v8_generated_peephole_source = "$target_gen_dir/bytecode-peephole-table.cc"
v8_random_seed = "314159265"
v8_toolset_for_shell = "host"
@@ -648,25 +647,6 @@
sources += [ v8_embed_script ]
args += [ rebase_path(v8_embed_script, root_build_dir) ]
}
-}
-
-action("run_mkpeephole") {
- visibility = [ ":*" ] # Only targets in this file can depend on this.
-
- deps = [ ":mkpeephole($v8_snapshot_toolchain)" ]
-
- outputs = [ v8_generated_peephole_source ]
-
- sources = []
-
- script = "tools/run.py"
-
- args = [
- "./" + rebase_path(get_label_info(":mkpeephole($v8_snapshot_toolchain)",
- "root_out_dir") + "/mkpeephole",
- root_build_dir),
- rebase_path(v8_generated_peephole_source, root_build_dir),
- ]
}
action("v8_dump_build_config") {
@@ -1331,7 +1311,6 @@
"src/interpreter/bytecode-label.h",
"src/interpreter/bytecode-peephole-optimizer.cc",
"src/interpreter/bytecode-peephole-optimizer.h",
- "src/interpreter/bytecode-peephole-table.h",
"src/interpreter/bytecode-pipeline.cc",
"src/interpreter/bytecode-pipeline.h",
"src/interpreter/bytecode-register-allocator.cc",
@@ -1930,9 +1909,6 @@
":v8_libsampler",
]
- sources += [ v8_generated_peephole_source ]
- deps += [ ":run_mkpeephole" ]
-
if (is_win) {
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
cflags = [ "/wd4267" ]
@@ -2156,31 +2132,6 @@
}
}
-v8_executable("mkpeephole") {
- # mkpeephole needs to be built for the build host so the peephole lookup
- # table can built during build. The table depends on the properties of
- # bytecodes that are described in bytecodes.{cc,h}.
- visibility = [ ":*" ] # Only targets in this file can depend on this.
-
- sources = [
- "src/interpreter/bytecode-peephole-optimizer.h",
- "src/interpreter/bytecodes.cc",
- "src/interpreter/bytecodes.h",
- "src/interpreter/mkpeephole.cc",
- ]
-
- configs = [
- ":external_config",
- ":internal_config",
- ]
-
- deps = [
- ":v8_libbase",
- "//build/config/sanitizers:deps",
- "//build/win:default_exe_manifest",
- ]
-}
-
###############################################################################
# Public targets
#
« no previous file with comments | « no previous file | src/interpreter/bytecode-peephole-optimizer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698