content/common/devtools_messages.h - Issue 2161493002: [DevTools] Pass client initiating DevToolsAgentHost::inspectElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/devtools_messages.h

Issue 2161493002: [DevTools] Pass client initiating DevToolsAgentHost::inspectElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/devtools/devtools_window.cc ('K') | « content/browser/devtools/render_frame_devtools_agent_host.cc ('k') | content/public/browser/devtools_agent_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/devtools_messages.h

diff --git a/content/common/devtools_messages.h b/content/common/devtools_messages.h

index 7a888762df84a49354cb3ee354089860cb4a4f8b..8bafd0a53cfc4f5e07987c021297c579b0b5447b 100644

--- a/content/common/devtools_messages.h

+++ b/content/common/devtools_messages.h

@@ -100,7 +100,8 @@ IPC_MESSAGE_ROUTED4(DevToolsAgentMsg_DispatchOnInspectorBackend,

std::string /* message */)

// Inspect element with the given coordinates.

-IPC_MESSAGE_ROUTED2(DevToolsAgentMsg_InspectElement,

+IPC_MESSAGE_ROUTED3(DevToolsAgentMsg_InspectElement,

+ int /* session_id */,

Tom Sepez 2016/07/18 16:15:49 Who generates session_id? Can we trust it? What

dgozman 2016/07/18 16:23:49 DevToolsAgentHostImpl generates one. This message

int /* x */,

int /* y */)