chrome/browser/devtools/devtools_window.cc - Issue 2161493002: [DevTools] Pass client initiating DevToolsAgentHost::inspectElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 2161493002: [DevTools] Pass client initiating DevToolsAgentHost::inspectElement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/devtools/devtools_window.cc

diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc

index 57879eab559af92fcf8277e95164abbaa359da29..2f15e36535585ea06a211d8ad999f58394622ee5 100644

--- a/chrome/browser/devtools/devtools_window.cc

+++ b/chrome/browser/devtools/devtools_window.cc

@@ -553,10 +553,10 @@ void DevToolsWindow::InspectElement(

OpenDevToolsWindow(Profile::FromBrowserContext(agent->GetBrowserContext()),

agent);

}

- agent->InspectElement(x, y);

DevToolsWindow* window = FindDevToolsWindow(agent.get());

+ if (window)

+ agent->InspectElement(window->bindings_, x, y);

if (should_measure_time && window)

Tom Sepez 2016/07/18 16:15:49 nit: combine with above to avoid re-testing |windo

dgozman 2016/07/18 19:55:58 Done.

window->inspect_element_start_time_ = start_time;

}

« no previous file with comments | « no previous file | content/browser/devtools/devtools_agent_host_impl.h » ('j') | content/common/devtools_messages.h » ('J')