Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2161383002:
Add check if depth and stencil attachments are same image (Closed)
DescriptionAdd check if depth and stencil attachments are same image
In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both
attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but
in OpenGL 4.3 spec there is no such restriction.
This patch adds the validation in command_buffer and updates the related unittests to meet
this restriction.
BUG=629735
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/b4b0966ca74a50608dc4e206f220dfff38783c88
Cr-Commit-Position: refs/heads/master@{#407309}
Patch Set 1 #Patch Set 2 : Add check if depth and stencil attachments are the same image when both attachments are present #
Total comments: 2
Patch Set 3 : Use IsSameAttachment and update related unittests #
Total comments: 7
Patch Set 4 : Fix some issues in unittest #Patch Set 5 : Add comments on unittest #
Total comments: 3
Patch Set 6 : Change NULL to nullptr #
Messages
Total messages: 44 (26 generated)
Description was changed from ========== Add check if depth and stencil attachments are the same image when both attachments are present In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no restriction. This patch adds validation in the command buffer to meet this restriction in WebGL 2 spec. BUG= ========== to ========== Add check if depth and stencil attachments are the same image when both attachments are present In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no restriction. This patch adds validation in the command buffer to meet this restriction in WebGL 2 spec. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Add check if depth and stencil attachments are the same image when both attachments are present In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no restriction. This patch adds validation in the command buffer to meet this restriction in WebGL 2 spec. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add check if depth and stencil attachments are the same image when both attachments are present In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no restriction. This patch adds validation in the command buffer to meet this restriction in WebGL 2 spec. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Add check if depth and stencil attachments are the same image when both attachments are present In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no restriction. This patch adds validation in the command buffer to meet this restriction in WebGL 2 spec. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add check if depth and stencil attachments are the same image when both attachments are present In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no restriction. This patch adds validation in the command buffer to meet this restriction in WebGL 2 spec. BUG=629735 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Add check if depth and stencil attachments are the same image when both attachments are present In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no restriction. This patch adds validation in the command buffer to meet this restriction in WebGL 2 spec. BUG=629735 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add check if depth and stencil attachments are the same image when both attachments are present In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no restriction. This patch adds the validation in command_buffer to meet this restriction in WebGL 2 spec. BUG=629735 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Add check if depth and stencil attachments are the same image when both attachments are present In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no restriction. This patch adds the validation in command_buffer to meet this restriction in WebGL 2 spec. BUG=629735 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add check if depth and stencil attachments are the same image when both attachments are present In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no such restriction. This patch adds the validation in command_buffer to meet this restriction in WebGL 2 spec. BUG=629735 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Patchset #2 (id:20001) has been deleted
jiawei.shao@intel.com changed reviewers: + qiankun.miao@intel.com
PTAL. Thanks!
Patchset #2 (id:40001) has been deleted
On 2016/07/20 at 06:37:05, jiawei.shao wrote: > PTAL. Thanks! LGTM, but you'll still need OWNER's review.
zmo@chromium.org changed reviewers: + piman@chromium.org, zmo@chromium.org
+piman https://codereview.chromium.org/2161383002/diff/60001/gpu/command_buffer/serv... File gpu/command_buffer/service/framebuffer_manager.cc (right): https://codereview.chromium.org/2161383002/diff/60001/gpu/command_buffer/serv... gpu/command_buffer/service/framebuffer_manager.cc:683: feature_info->context_type() == CONTEXT_TYPE_OPENGLES3) { We probably want to enforce this for all context types - even if it's es2 contexts, the underlying driver could still be es3, so it's better to just enforce this. https://codereview.chromium.org/2161383002/diff/60001/gpu/command_buffer/serv... gpu/command_buffer/service/framebuffer_manager.cc:690: if ((depth_it->second.get()->IsTextureAttachment() != This is incorrect. First, you also need to consider renderbuffer situation. Second, just by comparing the object id does not guarantee it's the same image. In the case of 3d textures, you could bind two different layers. In the case of cube textures, you could bind two different faces. In the case of 2d textures, you could bind two different levels. Please see https://codereview.chromium.org/2159183002/ and use the function added in that CL when it lands.
zmo is right on both counts.
jiawei.shao@intel.com changed reviewers: + yunchao.he@intel.com
Description was changed from ========== Add check if depth and stencil attachments are the same image when both attachments are present In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no such restriction. This patch adds the validation in command_buffer to meet this restriction in WebGL 2 spec. BUG=629735 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add check if depth and stencil attachments are the same image when both attachments are present In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no such restriction. This patch adds the validation in command_buffer and updates the related unittests to meet this restriction. BUG=629735 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Add check if depth and stencil attachments are the same image when both attachments are present In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no such restriction. This patch adds the validation in command_buffer and updates the related unittests to meet this restriction. BUG=629735 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add check if depth and stencil attachments are the same image when both attachments are present In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no such restriction. This patch adds the validation in command_buffer and updates the related unittests to meet this restriction. BUG=629735 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Add check if depth and stencil attachments are the same image when both attachments are present In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no such restriction. This patch adds the validation in command_buffer and updates the related unittests to meet this restriction. BUG=629735 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add check if depth and stencil attachments are same image when both attachments are present In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no such restriction. This patch adds the validation in command_buffer and updates the related unittests to meet this restriction. BUG=629735 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Add check if depth and stencil attachments are same image when both attachments are present In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no such restriction. This patch adds the validation in command_buffer and updates the related unittests to meet this restriction. BUG=629735 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add check if depth and stencil attachments are same image In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no such restriction. This patch adds the validation in command_buffer and updates the related unittests to meet this restriction. BUG=629735 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
https://codereview.chromium.org/2161383002/diff/80001/AUTHORS File AUTHORS (right): https://codereview.chromium.org/2161383002/diff/80001/AUTHORS#newcode296 AUTHORS:296: Jiawei Shao <jiawei.shao@intel.com> This isn't needed any more. Once your first patch landed. https://codereview.chromium.org/2161383002/diff/80001/gpu/command_buffer/serv... File gpu/command_buffer/service/framebuffer_manager.cc (right): https://codereview.chromium.org/2161383002/diff/80001/gpu/command_buffer/serv... gpu/command_buffer/service/framebuffer_manager.cc:752: AttachmentMap::const_iterator depth_it = attachments_.find( You can use GetAttachment() to get pointer of an attachment. https://codereview.chromium.org/2161383002/diff/80001/gpu/command_buffer/serv... File gpu/command_buffer/service/framebuffer_manager_unittest.cc (right): https://codereview.chromium.org/2161383002/diff/80001/gpu/command_buffer/serv... gpu/command_buffer/service/framebuffer_manager_unittest.cc:333: EXPECT_TRUE(framebuffer_->IsCleared()); We don't need to check isCleared for unsupported framebuffer. https://codereview.chromium.org/2161383002/diff/80001/gpu/command_buffer/serv... gpu/command_buffer/service/framebuffer_manager_unittest.cc:335: // Bind a renderbufer in format DEPTH_STENCIL to depth and stencil typo: renderbuffer https://codereview.chromium.org/2161383002/diff/80001/gpu/command_buffer/serv... gpu/command_buffer/service/framebuffer_manager_unittest.cc:462: EXPECT_EQ(static_cast<GLenum>(GL_FRAMEBUFFER_INCOMPLETE_DIMENSIONS_EXT), After STENCIL attachment is removed, depth attachment and stencil attachment are not the same one. Why it doesn't return FRAMEBUFFER_UNSUPPORTED?
On 2016/07/21 09:29:22, qiankun wrote: > https://codereview.chromium.org/2161383002/diff/80001/AUTHORS > File AUTHORS (right): > > https://codereview.chromium.org/2161383002/diff/80001/AUTHORS#newcode296 > AUTHORS:296: Jiawei Shao <mailto:jiawei.shao@intel.com> > This isn't needed any more. Once your first patch landed. > > https://codereview.chromium.org/2161383002/diff/80001/gpu/command_buffer/serv... > File gpu/command_buffer/service/framebuffer_manager.cc (right): > > https://codereview.chromium.org/2161383002/diff/80001/gpu/command_buffer/serv... > gpu/command_buffer/service/framebuffer_manager.cc:752: > AttachmentMap::const_iterator depth_it = attachments_.find( > You can use GetAttachment() to get pointer of an attachment. > > https://codereview.chromium.org/2161383002/diff/80001/gpu/command_buffer/serv... > File gpu/command_buffer/service/framebuffer_manager_unittest.cc (right): > > https://codereview.chromium.org/2161383002/diff/80001/gpu/command_buffer/serv... > gpu/command_buffer/service/framebuffer_manager_unittest.cc:333: > EXPECT_TRUE(framebuffer_->IsCleared()); > We don't need to check isCleared for unsupported framebuffer. > > https://codereview.chromium.org/2161383002/diff/80001/gpu/command_buffer/serv... > gpu/command_buffer/service/framebuffer_manager_unittest.cc:335: // Bind a > renderbufer in format DEPTH_STENCIL to depth and stencil > typo: renderbuffer > > https://codereview.chromium.org/2161383002/diff/80001/gpu/command_buffer/serv... > gpu/command_buffer/service/framebuffer_manager_unittest.cc:462: > EXPECT_EQ(static_cast<GLenum>(GL_FRAMEBUFFER_INCOMPLETE_DIMENSIONS_EXT), > After STENCIL attachment is removed, depth attachment and stencil attachment are > not the same one. Why it doesn't return FRAMEBUFFER_UNSUPPORTED? The validation of the height and width is executed before the check if depth and stencil attachments are the same image in function IsPossiblyComplete.
https://codereview.chromium.org/2161383002/diff/80001/gpu/command_buffer/serv... File gpu/command_buffer/service/framebuffer_manager_unittest.cc (right): https://codereview.chromium.org/2161383002/diff/80001/gpu/command_buffer/serv... gpu/command_buffer/service/framebuffer_manager_unittest.cc:462: EXPECT_EQ(static_cast<GLenum>(GL_FRAMEBUFFER_INCOMPLETE_DIMENSIONS_EXT), On 2016/07/21 09:29:21, qiankun wrote: > After STENCIL attachment is removed, depth attachment and stencil attachment are > not the same one. Why it doesn't return FRAMEBUFFER_UNSUPPORTED? You should reply in the review context. So the validation code in framebuffer_manager.cc is wrong. It should be moved to the beginning of IsPossiblyComplete().
https://codereview.chromium.org/2161383002/diff/80001/gpu/command_buffer/serv... File gpu/command_buffer/service/framebuffer_manager_unittest.cc (right): https://codereview.chromium.org/2161383002/diff/80001/gpu/command_buffer/serv... gpu/command_buffer/service/framebuffer_manager_unittest.cc:462: EXPECT_EQ(static_cast<GLenum>(GL_FRAMEBUFFER_INCOMPLETE_DIMENSIONS_EXT), On 2016/07/21 15:21:39, qiankun wrote: > On 2016/07/21 09:29:21, qiankun wrote: > > After STENCIL attachment is removed, depth attachment and stencil attachment > are > > not the same one. Why it doesn't return FRAMEBUFFER_UNSUPPORTED? > > You should reply in the review context. > So the validation code in framebuffer_manager.cc is wrong. It should be moved to > the beginning of IsPossiblyComplete(). After stencil attachment is removed, only depth attachment is present, which does not meet the condition of the added validation code.
Description was changed from ========== Add check if depth and stencil attachments are same image In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no such restriction. This patch adds the validation in command_buffer and updates the related unittests to meet this restriction. BUG=629735 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add check if depth and stencil attachments are same image In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no such restriction. This patch adds the validation in command_buffer and updates the related unittests to meet this restriction. BUG=629735 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
https://codereview.chromium.org/2161383002/diff/120001/gpu/command_buffer/ser... File gpu/command_buffer/service/framebuffer_manager_unittest.cc (right): https://codereview.chromium.org/2161383002/diff/120001/gpu/command_buffer/ser... gpu/command_buffer/service/framebuffer_manager_unittest.cc:340: ASSERT_TRUE(renderbuffer4 != NULL); Use nullptr here and other place. https://codereview.chromium.org/2161383002/diff/120001/gpu/command_buffer/ser... gpu/command_buffer/service/framebuffer_manager_unittest.cc:415: EXPECT_FALSE(framebuffer_->IsCleared()); Can you mark renderbuffer5 as cleared and check framebuffer_->IsCleared() is true here and line 464. https://codereview.chromium.org/2161383002/diff/120001/gpu/command_buffer/ser... gpu/command_buffer/service/framebuffer_manager_unittest.cc:454: // Restore the width of renderbuffer5 to avoid INCOMPLETE_DIMENSIONS_EXT Miss . at the end of line.
PTAL. Thanks!
Looks good to me. others: please review again. Thanks!
lgtm
The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by qiankun.miao@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from cwallez@chromium.org Link to the patchset: https://codereview.chromium.org/2161383002/#ps140001 (title: "Change NULL to nullptr")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by qiankun.miao@intel.com
qiankun.miao@intel.com changed reviewers: + kbr@chromium.org
ken: please take another look. If it's Ok, please help to check commit. Thanks!
The CQ bit was checked by qiankun.miao@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add check if depth and stencil attachments are same image In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no such restriction. This patch adds the validation in command_buffer and updates the related unittests to meet this restriction. BUG=629735 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add check if depth and stencil attachments are same image In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no such restriction. This patch adds the validation in command_buffer and updates the related unittests to meet this restriction. BUG=629735 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #6 (id:140001)
Message was sent while issue was closed.
Description was changed from ========== Add check if depth and stencil attachments are same image In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no such restriction. This patch adds the validation in command_buffer and updates the related unittests to meet this restriction. BUG=629735 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add check if depth and stencil attachments are same image In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no such restriction. This patch adds the validation in command_buffer and updates the related unittests to meet this restriction. BUG=629735 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/b4b0966ca74a50608dc4e206f220dfff38783c88 Cr-Commit-Position: refs/heads/master@{#407309} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/b4b0966ca74a50608dc4e206f220dfff38783c88 Cr-Commit-Position: refs/heads/master@{#407309}
Message was sent while issue was closed.
Sorry for the delay reviewing. LGTM after the fact. It was fine to CQ this without my review. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
