Add check if depth and stencil attachments are same image

gpu/command_buffer/service/framebuffer_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/framebuffer_manager.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "base/logging.h"
@@ skipping 729 matching lines @@
       for (GLenum i = it->first + 1;
            i < GL_COLOR_ATTACHMENT0 + manager_->max_color_attachments_; i++) {
         const Attachment* other = GetAttachment(i);
         if (other && attachment->IsSameAttachment(other)) {
           return GL_FRAMEBUFFER_UNSUPPORTED;
         }
       }
     }
   }
 
+  // Binding different images to depth and stencil attachment points should
+  // return FRAMEBUFFER_UNSUPPORTED.
+  AttachmentMap::const_iterator depth_it = attachments_.find(

[qiankun, 2016/07/21 09:29:21]

You can use GetAttachment() to get pointer of an attachment.

+                                               GL_DEPTH_ATTACHMENT);
+  AttachmentMap::const_iterator stencil_it = attachments_.find(
+                                               GL_STENCIL_ATTACHMENT);
+  if (depth_it != attachments_.end() && stencil_it != attachments_.end()) {
+    Attachment *depth_attachment = depth_it->second.get();
+    Attachment *stencil_attachment = stencil_it->second.get();
+    if (!depth_attachment->IsSameAttachment(stencil_attachment)) {
+      return GL_FRAMEBUFFER_UNSUPPORTED;
+    }
+  }
+
   // This does not mean the framebuffer is actually complete. It just means our
   // checks passed.
   return GL_FRAMEBUFFER_COMPLETE;
 }
 
 GLenum Framebuffer::GetStatus(
     TextureManager* texture_manager, GLenum target) const {
   if (!manager_->GetFramebufferComboCompleteCache()) {
     return glCheckFramebufferStatusEXT(target);
   }
@@ skipping 278 matching lines @@
 
 bool FramebufferManager::IsComplete(
     Framebuffer* framebuffer) {
   DCHECK(framebuffer);
   return framebuffer->framebuffer_complete_state_count_id() ==
       framebuffer_state_change_count_;
 }
 
 }  // namespace gles2
 }  // namespace gpu