Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 2161083004: [DO NOT COMMIT] MediaPlayerRenderer using StreamTextures. (Closed)

Created:
4 years, 5 months ago by tguilbert
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, Aaron Boodman, posciak+watch_chromium.org, avayvod+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin-cc_chromium.org, alokp+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, viettrungluu+watch_chromium.org, mlamouri+watch-media_chromium.org, Anton Obzhirov
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DO NOT COMMIT] MediaPlayerRenderer using StreamTextures. UPDATE: The relevant code is mostly checked in. Closing this issue. See the bugs tied to https://bugs.chromium.org/p/chromium/issues/detail?id=619729 in order to get the full picture of the code that landed. This code is still a prototype, and will be commited in smaller, cleaner CLs. Some of the comments are lacking and out of date, since the code has already changed. The prototype also blatantly hardcodes some values and leaks textures, and is not meant to be committed. I have also added many 'TODOs', both as a note to myself, and as a flag for readers as to what is likely to change. Some interfaces are also temporarily implemented as a stepping stone before removing WMPA. The rough order in which I intend to submit the code is: - StreamTextureWrapper (after the proper 'OnFrameAvailable' signalling has been decided upon). - MediaPlayerRenderer/MediaPlayerRendererHost. - The registration mechanism for the StreamTexture. - The full integration + flag for running experiments. Feel free to add comments here or to ping me offline! CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1373 lines, -34 lines) Patch
M content/browser/android/child_process_launcher_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/child_process_launcher_android.cc View 5 chunks +24 lines, -11 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 3 chunks +14 lines, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A content/renderer/media/android/stream_texture_wrapper_impl.h View 1 chunk +106 lines, -0 lines 0 comments Download
A content/renderer/media/android/stream_texture_wrapper_impl.cc View 1 chunk +175 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 4 chunks +20 lines, -2 lines 0 comments Download
M media/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M media/base/android/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
A media/base/android/media_player_renderer.h View 1 chunk +130 lines, -0 lines 0 comments Download
A media/base/android/media_player_renderer.cc View 1 chunk +249 lines, -0 lines 0 comments Download
A media/base/android/media_player_renderer_factory.h View 1 chunk +55 lines, -0 lines 0 comments Download
A media/base/android/media_player_renderer_factory.cc View 1 chunk +53 lines, -0 lines 0 comments Download
A media/base/android/stream_texture_wrapper.h View 1 chunk +44 lines, -0 lines 0 comments Download
M media/base/mock_filters.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/pipeline_impl.cc View 5 chunks +50 lines, -13 lines 0 comments Download
M media/base/renderer_client.h View 2 chunks +7 lines, -2 lines 0 comments Download
M media/blink/video_frame_compositor.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 2 chunks +7 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 7 chunks +18 lines, -1 line 1 comment Download
M media/media_options.gni View 1 chunk +5 lines, -0 lines 0 comments Download
M media/mojo/clients/mojo_renderer.h View 2 chunks +6 lines, -0 lines 0 comments Download
M media/mojo/clients/mojo_renderer.cc View 6 chunks +50 lines, -1 line 0 comments Download
M media/mojo/clients/mojo_renderer_factory.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M media/mojo/interfaces/renderer.mojom View 2 chunks +7 lines, -1 line 0 comments Download
M media/mojo/services/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download
M media/mojo/services/media_mojo_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
A media/mojo/services/mojo_media_player_renderer_helper.h View 1 chunk +23 lines, -0 lines 0 comments Download
A media/mojo/services/mojo_media_player_renderer_helper.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.h View 4 chunks +6 lines, -1 line 0 comments Download
M media/mojo/services/mojo_renderer_service.cc View 3 chunks +21 lines, -0 lines 0 comments Download
M media/renderers/audio_renderer_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
A media/renderers/media_player_renderer_host.h View 1 chunk +92 lines, -0 lines 0 comments Download
A media/renderers/media_player_renderer_host.cc View 1 chunk +149 lines, -0 lines 0 comments Download
M media/renderers/renderer_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Julien Isorce Samsung
4 years, 4 months ago (2016-08-08 12:58:01 UTC) #2
https://codereview.chromium.org/2161083004/diff/1/media/blink/webmediaplayer_...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/2161083004/diff/1/media/blink/webmediaplayer_...
media/blink/webmediaplayer_impl.cc:1370: return;
Hi, sorry for the short introduction, I was thinking of creating a new
MojoPipelineService but then I saw your solution that re-use MojoRenderer + this
pseudo demuxer that just passes the url. You said that creating a proper service
would have required too much unnecessary refactoring "Removing the Demuxer from
the pipeline when using a MediaPlayer would require a non-trivial amount of
refactoring, that might not be worth it."
So I was wondering if after all this work you are still thinking that there is
no need for a proper MojoPipelineService ?
Nice solution btw !

Powered by Google App Engine
This is Rietveld 408576698