Add a verification step which iterates over the heap and verifies that all canonical objects are co…

Add a verification step which iterates over the heap and verifies that all canonical objects are consistent (i.e canonicalizing the object returns the object).

Committed: https://github.com/dart-lang/sdk/commit/bd1895017b1e996b19f347684ec09ed2fb433996

[siva, 2016-07-22 22:56:20]

asiva@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-07-25 13:51:27]

LGTMwC

https://codereview.chromium.org/2160953002/diff/40001/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/2160953002/diff/40001/runtime/vm/isolate.cc#n...
runtime/vm/isolate.cc:1500: VerifyCanonicalVisitor check_canonical(thread);
Should this be:

#if defined(DEBUG)
if (!HasAttemptedReload()) {
  // TODO(asiva): Do this even if the isolate has been reloaded.
  isolate->heap()->CollectAllGarbage();
  VerifyCanonicalVisitor check_canonical(thread);
  isolate->heap()->IterateObjects(&check_canonical);
}
#endif

[siva, 2016-07-25 21:00:27]

https://codereview.chromium.org/2160953002/diff/40001/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/2160953002/diff/40001/runtime/vm/isolate.cc#n...
runtime/vm/isolate.cc:1500: VerifyCanonicalVisitor check_canonical(thread);
On 2016/07/25 13:51:26, Cutch wrote:
> Should this be:
> 
> #if defined(DEBUG)
> if (!HasAttemptedReload()) {
>   // TODO(asiva): Do this even if the isolate has been reloaded.
>   isolate->heap()->CollectAllGarbage();
>   VerifyCanonicalVisitor check_canonical(thread);
>   isolate->heap()->IterateObjects(&check_canonical);
> }
> #endif

Done for now, After fixing the issues I am seeing when reloading this can be
made unconditional.

[siva, 2016-07-25 21:35:16]

Description was changed from

==========
Add a verification step which iterates over the heap and verifies that all
canonical objects are consistent (i.e canonicalizing the object returns the
object).
==========

to

==========
Add a verification step which iterates over the heap and verifies that all
canonical objects are consistent (i.e canonicalizing the object returns the
object).

Committed:
https://github.com/dart-lang/sdk/commit/bd1895017b1e996b19f347684ec09ed2fb433996
==========

[siva, 2016-07-25 21:35:17]

Committed patchset #4 (id:60001) manually as
bd1895017b1e996b19f347684ec09ed2fb433996 (presubmit successful).